Add a new longer sling to the game, along with #81870
Conversation
name changes to help with distinguishing between the two. Throwing weapons need some love
You don't need to compile to test JSON changes, the game ships with all the JSON data so you can just download experimental and apply your changes to that, it's obviously more convenient if you have a local git repo setup tho which you can just sync when the release you're downloading comes out and then just copy the compiled exe from the release to your local repo for testing |
data/json/items/ranged/slings.json
Outdated
| @@ -1,6 +1,6 @@ | |||
| [ | |||
| { | |||
| "id": "sling", | |||
| "id": "shepherd's_sling", | |||
There was a problem hiding this comment.
| "id": "shepherd's_sling", | |
| "id": "sling", |
That's the id the game uses not the name, if you change this without migration everyone with a save with a sling in will no longer have a sling, we avoid changing ids when it's not necessary. You want to change the name str field a few lines down
data/json/items/ranged/slings.json
Outdated
| "id": "long_shepherd's_sling", | ||
| "looks_like": "slingshot", | ||
| "type": "ITEM", | ||
| "subtypes": [ "GUN" ], | ||
| "symbol": "(", | ||
| "color": "brown", | ||
| "name": { "ctxt": "weapon", "str": "sling" }, |
There was a problem hiding this comment.
| "id": "long_shepherd's_sling", | |
| "looks_like": "slingshot", | |
| "type": "ITEM", | |
| "subtypes": [ "GUN" ], | |
| "symbol": "(", | |
| "color": "brown", | |
| "name": { "ctxt": "weapon", "str": "sling" }, | |
| "id": "sling_long", | |
| "looks_like": "slingshot", | |
| "type": "ITEM", | |
| "subtypes": [ "GUN" ], | |
| "symbol": "(", | |
| "color": "brown", | |
| "name": { "ctxt": "weapon", "str": "shepherd's sling" }, |
data/json/items/ranged/slings.json
Outdated
| @@ -122,4 +122,31 @@ | |||
| "reload": 50, | |||
| "pocket_data": [ { "pocket_type": "MAGAZINE", "ammo_restriction": { "pebble": 1 }, "open_container": true } ] | |||
| } | |||
There was a problem hiding this comment.
| } | |
| }, |
Also just missing a comma here
|
cool, work on them in a bit |
|
Are there any CBMs that provide a throwing endgame weapon? Like extra joint torque or a visual lock-on system that would help with aim? |
github-actions
bot
added
the
astyled
data/json/items/ranged/slings.json
Outdated
| "symbol": "(", | ||
| "color": "brown", | ||
| "name": { "ctxt": "weapon", "str": "long shepherd's sling" }, | ||
| "description": "A longer sling, still easy to use and accurate. It uses pebbles as ammunition. It also packs a bigger punch", |
There was a problem hiding this comment.
| "description": "A longer sling, still easy to use and accurate. It uses pebbles as ammunition. It also packs a bigger punch", | |
| "description": "A longer sling, still easy to use and accurate. It uses pebbles as ammunition. It also packs a bigger punch.", |
It also packs a bigger punch.
Ranged damage is the same
🤔
There was a problem hiding this comment.
haha, yeah good catch though i'm still on the fence about that, is 1,5 times more damage a reasonable amount? or is it too small, what do you think?
hmm i didn't consider that? though for characters who don't have access to CBMs this seems pretty good |
data/json/items/ranged/slings.json
Outdated
| @@ -6,7 +6,7 @@ | |||
| "subtypes": [ "GUN" ], | |||
| "symbol": "(", | |||
| "color": "brown", | |||
| "name": { "ctxt": "weapon", "str": "sling" }, | |||
| "name": { "ctxt": "weapon", "str": "shepherd's sling" }, | |||
There was a problem hiding this comment.
We discussed this, I don't agree that this clarified anything, sling is fine, or short sling to distinguish it from the long sling.
github-actions
bot
added
the
json-styled
data/json/items/ranged/slings.json
Outdated
| "weight": "105 g", | ||
| "volume": "90 ml", |
There was a problem hiding this comment.
i doubt it should be just 90 ml, and our density test agrees
name changes to help with distinguishing between the two. Throwing weapons need some love
Summary
Content "Adds new longer sling"
Purpose of change
throwing weapons need some more love
Describe the solution
just a copy of the old sling changed around a bit, the numbers for the new longer sling are just from gut. I'll need to change things around a bit. It is however intended to be twice as long
Describe alternatives you've considered
we could make the sling longer but that seems like trying to stretch one item too far, in reality the actual sling can be whatever length is necessary but ive chosen to make a sling twice the length of the old one
Testing
No tests have been done just yet as compiling isn't really practically possible on my machine.
Additional context