Split river/lake/ocean-related functions from overmap.cpp #81878
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Map / Mapgen
ShnitzelX2
force-pushed
the
split-overmap
branch
from
76ce93b to
8824a03
Compare
github-actions
bot
added
the
BasicBuildPassed
ShnitzelX2
force-pushed
the
split-overmap
branch
from
8824a03 to
0e7f5b4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
None
Purpose of change
overmap.cpp is 8000+ lines, break it up where convenient
Describe the solution
Moves code from overmap.cpp to overmap_water.cpp, no functional changes.
Describe alternatives you've considered
Testing
Compiled successfully, loaded game
Additional context
For some reason flood_fill.h was giving me compile errors, so I'm going to double-check IWYU.