Skip to content

migrate "longarm bag" item #81883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 18, 2025
Merged

Conversation

dynst
Copy link
Contributor

@dynst dynst commented Jul 17, 2025

Summary

Content "Obsolete longarm bags"

Purpose of change

A longarm bag does not exist. The term "longarm bag" does not exist. The term looks like an awkward name coined in #42386 for its invention of a duffelbag intended to hold rifles without using the word "rifle." But in real life rifles are generally held in rifle cases (added a few months later in #43466). And no real duffelbag with that volume capacity has 1 extremely long length dimension like this item does (50L but 150 cm long?).

Describe the solution

Replace it with a duffelbag.

Describe alternatives you've considered

Testing

Additional context

The duffelbag is currently larger than the long_duffelbag ever was, though not with the same absurd length. #81101

#81553

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Items: Armor / Clothing Armor and clothing astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Jul 17, 2025
dynst added 2 commits July 18, 2025 00:11
This player-craftable item was designed based on no real world
item, and looks like it was created because rifle cases didn't exist
yet at the time.

It isn't a duffelbag, it isn't a rifle case, its dimensions make
zero sense, it isn't a dessert OR a floor wax.
@dynst dynst force-pushed the duffel-long-obsolete branch from 245fd7b to bd688f1 Compare July 18, 2025 00:11
@github-actions github-actions bot added Code: Tests Measurement, self-control, statistics, balancing. [C++] Changes (can be) made in C++. Previously named `Code` labels Jul 18, 2025
use an item that lacks a speedy pocket for long items.
arrow_wood is 76cm.
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Jul 18, 2025
@GuardianDll GuardianDll merged commit 916d1aa into CleverRaven:master Jul 18, 2025
30 of 31 checks passed
@mahpell
Copy link

mahpell commented Jul 18, 2025

I... kind of disagree? There is no "longarm bag", but there is a "gunrunner pack" type of bag. It isn't 150 cm long, but it has the special scabbard for the fully assembled gun at the back, usually longer than the rest of the backpack. The stock is obviously sticking out of the scabbard, but still, this kind of bags is very real.

@dynst
Copy link
Contributor Author

dynst commented Jul 18, 2025

Unfortunately when I asked if anyone had seen longarm bags for sale all anyone came up with were basically rifle cases. #81101 (comment)

This looks so different it would make sense as a whole new (much smaller) item. https://eberlestock.com/products/gunrunner-pack

    Volume: 1,275 c.i. / 20.89L
    Weight: 3.95 lbs
    Dimensions:  25.5H x 8.25W x 8.5D
    Scabbard Dimensions 34" H x 7" W x 3" D
    Scabbard Volume: 400 c.i.

But fortunately, for now, a standard duffelbag already has a rifle-storing 'pocket' that allows storing an item as long as 100 cm added in #53162 (so, it didn't exist when long_duffelbag was designed).

@mahpell
Copy link

mahpell commented Jul 18, 2025

Yeah, I guess it can work. There are lots of different sizes and volumes, though:
https://eberlestock.com/products/x1-euro

Total Volume:
2100 c.i. (without scabbard) / 34.4L
Weight:
Camo - 6lb 3 oz. , Solid - 5lb 14 oz.
Dimensions main bag:
24"H x 12"W x 10"D

Some are even with a full-size scabbard that include stock:

https://eberlestock.com/products/phantom-sniper-pack

Volume:
2600 c.i. / 42.6L
Weight:
9lbs 6oz
Dimensions:
24.5H x 19W x 10.5W
Scabbard:
34"L x 10"W x 3"D, 26" circumference opening

I can see it as separate military-themed lineup of bags.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [C++] Changes (can be) made in C++. Previously named `Code` Code: Tests Measurement, self-control, statistics, balancing. Items: Armor / Clothing Armor and clothing [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants