Skip to content

Add pattern isolation invariant to adaptive sampling spec - #49333

Open
blt wants to merge 1 commit into
blt/spec_adapative_sampling_credit_mechanismfrom
blt/add_pattern_isolation_invariant_to_adaptive_sampling_spec
Open

Add pattern isolation invariant to adaptive sampling spec#49333
blt wants to merge 1 commit into
blt/spec_adapative_sampling_credit_mechanismfrom
blt/add_pattern_isolation_invariant_to_adaptive_sampling_spec

Conversation

@blt

@blt blt commented Apr 14, 2026

Copy link
Copy Markdown
Contributor

What does this PR do?

This commit specifies when two sequences will not match, adding a fuzz test to ensure the claim. Technically this is implied by inversion with
the pre-existing ThresholdComparison however -- belt and suspenders -- in cases where multiple inversions are possible my preference is to
specify the contrapositive.

No changes here to production code.

Motivation

SMP forward deploy is looking to create an externally validated property test for adaptive sampling. Scoping the problem to validation of the integration of individually fit-for-purpose components is a tidier problem than otherwise.

blt commented Apr 14, 2026

Copy link
Copy Markdown
Contributor Author

@blt blt added the medium review PR review might take time label Apr 14, 2026 — with Graphite App
@blt blt removed the medium review PR review might take time label Apr 14, 2026
@blt
blt marked this pull request as ready for review April 14, 2026 17:22
@blt
blt requested a review from a team as a April 14, 2026 17:22
@blt
blt force-pushed the blt/add_pattern_isolation_invariant_to_adaptive_sampling_spec branch from 3dd805e to a417a7a Compare April 14, 2026 17:25
@blt
blt force-pushed the blt/spec_adapative_sampling_credit_mechanism branch from 2b93cd6 to 140f5ae Compare April 14, 2026 17:25
@dd-octo-sts

dd-octo-sts Bot commented Apr 14, 2026

Copy link
Copy Markdown
Contributor

Files inventory check summary

File checks results against ancestor 8d2a9c6a:

Results for datadog-agent_7.80.0~devel.git.351.f53d425.pipeline.110503988-1_amd64.deb:

No change detected

@cit-pr-commenter-54b7da

cit-pr-commenter-54b7da Bot commented Apr 14, 2026

Copy link
Copy Markdown

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: e528cd94-c951-4608-bef4-60bd98ed1be6

Baseline: 8d2a9c6
Comparison: f53d425
Diff

Optimization Goals: ✅ No significant changes detected

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI trials links
docker_containers_cpu % cpu utilization -1.82 [-4.69, +1.06] 1 Logs

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
quality_gate_metrics_logs memory utilization +0.50 [+0.24, +0.76] 1 Logs bounds checks dashboard
quality_gate_idle memory utilization +0.27 [+0.22, +0.31] 1 Logs bounds checks dashboard
ddot_metrics_sum_delta memory utilization +0.16 [-0.02, +0.34] 1 Logs
ddot_metrics memory utilization +0.15 [-0.04, +0.34] 1 Logs
file_to_blackhole_1000ms_latency egress throughput +0.15 [-0.29, +0.59] 1 Logs
ddot_metrics_sum_cumulative memory utilization +0.12 [-0.04, +0.28] 1 Logs
docker_containers_memory memory utilization +0.09 [-0.01, +0.19] 1 Logs
file_tree memory utilization +0.08 [+0.03, +0.13] 1 Logs
file_to_blackhole_100ms_latency egress throughput +0.05 [-0.06, +0.17] 1 Logs
ddot_logs memory utilization +0.04 [-0.02, +0.10] 1 Logs
file_to_blackhole_500ms_latency egress throughput +0.02 [-0.38, +0.41] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.09, +0.09] 1 Logs
uds_dogstatsd_to_api ingress throughput -0.01 [-0.21, +0.19] 1 Logs
uds_dogstatsd_to_api_v3 ingress throughput -0.02 [-0.21, +0.18] 1 Logs
file_to_blackhole_0ms_latency egress throughput -0.07 [-0.55, +0.41] 1 Logs
uds_dogstatsd_20mb_12k_contexts_20_senders memory utilization -0.13 [-0.18, -0.08] 1 Logs
tcp_syslog_to_blackhole ingress throughput -0.27 [-0.43, -0.10] 1 Logs
quality_gate_idle_all_features memory utilization -0.28 [-0.32, -0.24] 1 Logs bounds checks dashboard
otlp_ingest_logs memory utilization -0.51 [-0.61, -0.42] 1 Logs
ddot_metrics_sum_cumulativetodelta_exporter memory utilization -0.52 [-0.76, -0.29] 1 Logs
otlp_ingest_metrics memory utilization -0.57 [-0.72, -0.41] 1 Logs
quality_gate_logs % cpu utilization -1.10 [-2.08, -0.12] 1 Logs bounds checks dashboard
docker_containers_cpu % cpu utilization -1.82 [-4.69, +1.06] 1 Logs

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed observed_value links
docker_containers_cpu simple_check_run 10/10 706 ≥ 26
docker_containers_memory memory_usage 10/10 242.93MiB ≤ 370MiB
docker_containers_memory simple_check_run 10/10 700 ≥ 26
file_to_blackhole_0ms_latency memory_usage 10/10 0.16GiB ≤ 1.20GiB
file_to_blackhole_0ms_latency missed_bytes 10/10 0B = 0B
file_to_blackhole_1000ms_latency memory_usage 10/10 0.21GiB ≤ 1.20GiB
file_to_blackhole_1000ms_latency missed_bytes 10/10 0B = 0B
file_to_blackhole_100ms_latency memory_usage 10/10 0.17GiB ≤ 1.20GiB
file_to_blackhole_100ms_latency missed_bytes 10/10 0B = 0B
file_to_blackhole_500ms_latency memory_usage 10/10 0.18GiB ≤ 1.20GiB
file_to_blackhole_500ms_latency missed_bytes 10/10 0B = 0B
quality_gate_idle intake_connections 10/10 3 ≤ 4 bounds checks dashboard
quality_gate_idle memory_usage 10/10 141.15MiB ≤ 147MiB bounds checks dashboard
quality_gate_idle_all_features intake_connections 10/10 3 ≤ 4 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 466.87MiB ≤ 495MiB bounds checks dashboard
quality_gate_logs intake_connections 10/10 4 ≤ 6 bounds checks dashboard
quality_gate_logs memory_usage 10/10 173.75MiB ≤ 195MiB bounds checks dashboard
quality_gate_logs missed_bytes 10/10 0B = 0B bounds checks dashboard
quality_gate_metrics_logs cpu_usage 10/10 360.51 ≤ 2000 bounds checks dashboard
quality_gate_metrics_logs intake_connections 10/10 4 ≤ 6 bounds checks dashboard
quality_gate_metrics_logs memory_usage 10/10 382.46MiB ≤ 430MiB bounds checks dashboard
quality_gate_metrics_logs missed_bytes 10/10 0B = 0B bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.

@blt
blt force-pushed the blt/spec_adapative_sampling_credit_mechanism branch from 140f5ae to fb53ef1 Compare April 14, 2026 22:17
@blt
blt force-pushed the blt/add_pattern_isolation_invariant_to_adaptive_sampling_spec branch 2 times, most recently from c580952 to 480d440 Compare April 14, 2026 23:14
@blt
blt force-pushed the blt/spec_adapative_sampling_credit_mechanism branch 2 times, most recently from 3eeeee5 to 5040896 Compare April 15, 2026 15:06
@blt
blt force-pushed the blt/add_pattern_isolation_invariant_to_adaptive_sampling_spec branch from 480d440 to 2197af2 Compare April 15, 2026 15:06
This commit specifies when two sequences will not match, adding a fuzz
test to ensure the claim. Technically this is implied by inversion with
the pre-existing ThresholdComparison however -- belt and suspenders --
in cases where multiple inversions are possible my preference is to
specify the contrapositive.

No changes here to production code.
@blt
blt force-pushed the blt/add_pattern_isolation_invariant_to_adaptive_sampling_spec branch from 2197af2 to f53d425 Compare April 29, 2026 16:45
@blt
blt force-pushed the blt/spec_adapative_sampling_credit_mechanism branch from 5040896 to 72f09a9 Compare April 29, 2026 16:45
@datadog-prod-us1-4

datadog-prod-us1-4 Bot commented Apr 29, 2026

Copy link
Copy Markdown
Contributor

🎯 Code Coverage (details)
Patch Coverage: 100.00%
Overall Coverage: 50.21% (-0.00%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: f53d425 | Docs | Datadog PR Page | Give us feedback!

@dd-octo-sts

dd-octo-sts Bot commented Apr 29, 2026

Copy link
Copy Markdown
Contributor

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor 8d2a9c6
📊 Static Quality Gates Dashboard
🔗 SQG Job

Successful checks

Info

Quality gate Change Size (prev → curr → max)
docker_agent_jmx_amd64 -4.22 KiB (0.00% reduction) 991.664 → 991.660 → 996.590
29 successful checks with minimal change (< 2 KiB)
Quality gate Current Size
agent_deb_amd64 740.285 MiB
agent_deb_amd64_fips 698.692 MiB
agent_heroku_amd64 309.138 MiB
agent_rpm_amd64 740.269 MiB
agent_rpm_amd64_fips 698.676 MiB
agent_rpm_arm64 718.328 MiB
agent_rpm_arm64_fips 679.763 MiB
agent_suse_amd64 740.269 MiB
agent_suse_amd64_fips 698.676 MiB
agent_suse_arm64 718.328 MiB
agent_suse_arm64_fips 679.763 MiB
docker_agent_amd64 800.744 MiB
docker_agent_arm64 803.612 MiB
docker_agent_jmx_arm64 983.310 MiB
docker_cluster_agent_amd64 206.402 MiB
docker_cluster_agent_arm64 220.508 MiB
docker_cws_instrumentation_amd64 7.142 MiB
docker_cws_instrumentation_arm64 6.689 MiB
docker_dogstatsd_amd64 39.351 MiB
docker_dogstatsd_arm64 37.565 MiB
dogstatsd_deb_amd64 30.005 MiB
dogstatsd_deb_arm64 28.146 MiB
dogstatsd_rpm_amd64 30.005 MiB
dogstatsd_suse_amd64 30.005 MiB
iot_agent_deb_amd64 44.404 MiB
iot_agent_deb_arm64 41.392 MiB
iot_agent_deb_armhf 42.124 MiB
iot_agent_rpm_amd64 44.404 MiB
iot_agent_suse_amd64 44.404 MiB
On-wire sizes (compressed)
Quality gate Change Size (prev → curr → max)
agent_deb_amd64 -15.03 KiB (0.01% reduction) 175.054 → 175.040 → 179.160
agent_deb_amd64_fips +35.06 KiB (0.02% increase) 166.767 → 166.801 → 174.440
agent_heroku_amd64 neutral 74.922 MiB → 80.310
agent_rpm_amd64 neutral 177.034 MiB → 182.080
agent_rpm_amd64_fips +21.88 KiB (0.01% increase) 168.191 → 168.212 → 174.140
agent_rpm_arm64 -19.85 KiB (0.01% reduction) 159.267 → 159.248 → 163.610
agent_rpm_arm64_fips -3.77 KiB (0.00% reduction) 151.543 → 151.539 → 156.850
agent_suse_amd64 neutral 177.034 MiB → 182.080
agent_suse_amd64_fips +21.88 KiB (0.01% increase) 168.191 → 168.212 → 174.140
agent_suse_arm64 -19.85 KiB (0.01% reduction) 159.267 → 159.248 → 163.610
agent_suse_arm64_fips -3.77 KiB (0.00% reduction) 151.543 → 151.539 → 156.850
docker_agent_amd64 neutral 267.387 MiB → 272.990
docker_agent_arm64 -2.07 KiB (0.00% reduction) 254.405 → 254.403 → 261.470
docker_agent_jmx_amd64 -5.3 KiB (0.00% reduction) 336.042 → 336.037 → 341.610
docker_agent_jmx_arm64 neutral 319.041 MiB → 326.050
docker_cluster_agent_amd64 neutral 72.334 MiB → 73.460
docker_cluster_agent_arm64 neutral 67.802 MiB → 68.680
docker_cws_instrumentation_amd64 neutral 2.999 MiB → 3.330
docker_cws_instrumentation_arm64 neutral 2.729 MiB → 3.090
docker_dogstatsd_amd64 neutral 15.231 MiB → 15.870
docker_dogstatsd_arm64 neutral 14.546 MiB → 14.890
dogstatsd_deb_amd64 neutral 7.937 MiB → 8.830
dogstatsd_deb_arm64 neutral 6.821 MiB → 7.750
dogstatsd_rpm_amd64 neutral 7.948 MiB → 8.840
dogstatsd_suse_amd64 neutral 7.948 MiB → 8.840
iot_agent_deb_amd64 -2.6 KiB (0.02% reduction) 11.690 → 11.688 → 13.210
iot_agent_deb_arm64 neutral 9.990 MiB → 11.620
iot_agent_deb_armhf neutral 10.191 MiB → 11.780
iot_agent_rpm_amd64 neutral 11.707 MiB → 13.230
iot_agent_suse_amd64 neutral 11.707 MiB → 13.230

@quentinus95 quentinus95 added stale internal Identify a non-fork PR labels Aug 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

internal Identify a non-fork PR stale

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants