-
Notifications
You must be signed in to change notification settings - Fork 311
Report all set configuration sources to telemetry #9273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
mtoffl01
wants to merge
7
commits into
master
Choose a base branch
from
mtoff/config-sources
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 1 performance regressions! Performance is the same for 45 metrics, 13 unstable metrics.
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.51.1-SNAPSHOT~31e2345148, baseline=1.51.1-SNAPSHOT~6b55bdc9d0
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.042 s) : 0, 1041944
Total [baseline] (8.616 s) : 0, 8615898
Agent [candidate] (1.078 s) : 0, 1078223
Total [candidate] (8.617 s) : 0, 8617118
section iast
Agent [baseline] (1.17 s) : 0, 1169885
Total [baseline] (9.345 s) : 0, 9344944
Agent [candidate] (1.175 s) : 0, 1174974
Total [candidate] (9.298 s) : 0, 9298230
gantt
title insecure-bank - break down per module: candidate=1.51.1-SNAPSHOT~31e2345148, baseline=1.51.1-SNAPSHOT~6b55bdc9d0
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.43 ms) : 0, 1430
crashtracking [candidate] (1.475 ms) : 0, 1475
BytebuddyAgent [baseline] (729.678 ms) : 0, 729678
BytebuddyAgent [candidate] (754.478 ms) : 0, 754478
GlobalTracer [baseline] (241.538 ms) : 0, 241538
GlobalTracer [candidate] (248.37 ms) : 0, 248370
AppSec [baseline] (30.423 ms) : 0, 30423
AppSec [candidate] (31.338 ms) : 0, 31338
Debugger [baseline] (5.993 ms) : 0, 5993
Debugger [candidate] (6.19 ms) : 0, 6190
Remote Config [baseline] (648.113 µs) : 0, 648
Remote Config [candidate] (682.403 µs) : 0, 682
Telemetry [baseline] (11.264 ms) : 0, 11264
Telemetry [candidate] (14.202 ms) : 0, 14202
section iast
crashtracking [baseline] (1.428 ms) : 0, 1428
crashtracking [candidate] (1.422 ms) : 0, 1422
BytebuddyAgent [baseline] (844.634 ms) : 0, 844634
BytebuddyAgent [candidate] (848.791 ms) : 0, 848791
GlobalTracer [baseline] (231.994 ms) : 0, 231994
GlobalTracer [candidate] (231.477 ms) : 0, 231477
IAST [baseline] (27.184 ms) : 0, 27184
IAST [candidate] (29.014 ms) : 0, 29014
AppSec [baseline] (27.485 ms) : 0, 27485
AppSec [candidate] (28.78 ms) : 0, 28780
Debugger [baseline] (7.539 ms) : 0, 7539
Debugger [candidate] (5.953 ms) : 0, 5953
Remote Config [baseline] (601.81 µs) : 0, 602
Remote Config [candidate] (616.607 µs) : 0, 617
Telemetry [baseline] (8.064 ms) : 0, 8064
Telemetry [candidate] (7.965 ms) : 0, 7965
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.51.1-SNAPSHOT~31e2345148, baseline=1.51.1-SNAPSHOT~6b55bdc9d0
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.046 s) : 0, 1046296
Total [baseline] (10.61 s) : 0, 10609618
Agent [candidate] (1.046 s) : 0, 1046451
Total [candidate] (10.658 s) : 0, 10657821
section appsec
Agent [baseline] (1.22 s) : 0, 1219739
Total [baseline] (10.775 s) : 0, 10775327
Agent [candidate] (1.222 s) : 0, 1222104
Total [candidate] (10.792 s) : 0, 10792270
section iast
Agent [baseline] (1.172 s) : 0, 1171982
Total [baseline] (10.885 s) : 0, 10885332
Agent [candidate] (1.186 s) : 0, 1186275
Total [candidate] (10.908 s) : 0, 10907571
section profiling
Agent [baseline] (1.189 s) : 0, 1189440
Total [baseline] (10.846 s) : 0, 10846071
Agent [candidate] (1.195 s) : 0, 1194591
Total [candidate] (10.882 s) : 0, 10881849
gantt
title petclinic - break down per module: candidate=1.51.1-SNAPSHOT~31e2345148, baseline=1.51.1-SNAPSHOT~6b55bdc9d0
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.437 ms) : 0, 1437
crashtracking [candidate] (1.443 ms) : 0, 1443
BytebuddyAgent [baseline] (733.062 ms) : 0, 733062
BytebuddyAgent [candidate] (734.214 ms) : 0, 734214
GlobalTracer [baseline] (242.878 ms) : 0, 242878
GlobalTracer [candidate] (241.929 ms) : 0, 241929
AppSec [baseline] (30.507 ms) : 0, 30507
AppSec [candidate] (30.551 ms) : 0, 30551
Debugger [baseline] (6.074 ms) : 0, 6074
Debugger [candidate] (6.081 ms) : 0, 6081
Remote Config [baseline] (648.028 µs) : 0, 648
Remote Config [candidate] (651.011 µs) : 0, 651
Telemetry [baseline] (10.627 ms) : 0, 10627
Telemetry [candidate] (10.497 ms) : 0, 10497
section appsec
crashtracking [baseline] (1.445 ms) : 0, 1445
crashtracking [candidate] (1.426 ms) : 0, 1426
BytebuddyAgent [baseline] (752.908 ms) : 0, 752908
BytebuddyAgent [candidate] (755.766 ms) : 0, 755766
GlobalTracer [baseline] (235.058 ms) : 0, 235058
GlobalTracer [candidate] (234.413 ms) : 0, 234413
IAST [baseline] (23.526 ms) : 0, 23526
IAST [candidate] (23.561 ms) : 0, 23561
AppSec [baseline] (168.843 ms) : 0, 168843
AppSec [candidate] (169.488 ms) : 0, 169488
Debugger [baseline] (7.943 ms) : 0, 7943
Debugger [candidate] (5.754 ms) : 0, 5754
Remote Config [baseline] (614.985 µs) : 0, 615
Remote Config [candidate] (602.747 µs) : 0, 603
Telemetry [baseline] (8.252 ms) : 0, 8252
Telemetry [candidate] (9.832 ms) : 0, 9832
section iast
crashtracking [baseline] (1.432 ms) : 0, 1432
crashtracking [candidate] (1.445 ms) : 0, 1445
BytebuddyAgent [baseline] (846.053 ms) : 0, 846053
BytebuddyAgent [candidate] (857.849 ms) : 0, 857849
GlobalTracer [baseline] (231.815 ms) : 0, 231815
GlobalTracer [candidate] (232.939 ms) : 0, 232939
IAST [baseline] (28.154 ms) : 0, 28154
IAST [candidate] (28.414 ms) : 0, 28414
AppSec [baseline] (28.035 ms) : 0, 28035
AppSec [candidate] (29.847 ms) : 0, 29847
Debugger [baseline] (6.683 ms) : 0, 6683
Debugger [candidate] (5.928 ms) : 0, 5928
Remote Config [baseline] (580.01 µs) : 0, 580
Remote Config [candidate] (639.291 µs) : 0, 639
Telemetry [baseline] (8.147 ms) : 0, 8147
Telemetry [candidate] (8.096 ms) : 0, 8096
section profiling
crashtracking [baseline] (1.39 ms) : 0, 1390
crashtracking [candidate] (1.424 ms) : 0, 1424
BytebuddyAgent [baseline] (757.147 ms) : 0, 757147
BytebuddyAgent [candidate] (759.576 ms) : 0, 759576
GlobalTracer [baseline] (220.98 ms) : 0, 220980
GlobalTracer [candidate] (221.179 ms) : 0, 221179
AppSec [baseline] (30.144 ms) : 0, 30144
AppSec [candidate] (30.573 ms) : 0, 30573
Debugger [baseline] (6.272 ms) : 0, 6272
Debugger [candidate] (6.197 ms) : 0, 6197
Remote Config [baseline] (683.519 µs) : 0, 684
Remote Config [candidate] (642.588 µs) : 0, 643
Telemetry [baseline] (15.142 ms) : 0, 15142
Telemetry [candidate] (15.225 ms) : 0, 15225
ProfilingAgent [baseline] (108.463 ms) : 0, 108463
ProfilingAgent [candidate] (108.941 ms) : 0, 108941
Profiling [baseline] (109.095 ms) : 0, 109095
Profiling [candidate] (109.532 ms) : 0, 109532
LoadParameters
See matching parameters
SummaryFound 4 performance improvements and 0 performance regressions! Performance is the same for 8 metrics, 12 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.51.1-SNAPSHOT~31e2345148, baseline=1.51.1-SNAPSHOT~6b55bdc9d0
dateFormat X
axisFormat %s
section baseline
no_agent (36.392 ms) : 36097, 36687
. : milestone, 36392,
appsec (48.898 ms) : 48467, 49328
. : milestone, 48898,
code_origins (43.956 ms) : 43582, 44330
. : milestone, 43956,
iast (44.71 ms) : 44332, 45087
. : milestone, 44710,
profiling (49.006 ms) : 48573, 49439
. : milestone, 49006,
tracing (45.26 ms) : 44875, 45646
. : milestone, 45260,
section candidate
no_agent (36.724 ms) : 36427, 37022
. : milestone, 36724,
appsec (47.145 ms) : 46716, 47573
. : milestone, 47145,
code_origins (43.301 ms) : 42929, 43674
. : milestone, 43301,
iast (44.451 ms) : 44055, 44847
. : milestone, 44451,
profiling (46.649 ms) : 46254, 47044
. : milestone, 46649,
tracing (42.888 ms) : 42515, 43261
. : milestone, 42888,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.51.1-SNAPSHOT~31e2345148, baseline=1.51.1-SNAPSHOT~6b55bdc9d0
dateFormat X
axisFormat %s
section baseline
no_agent (4.33 ms) : 4277, 4384
. : milestone, 4330,
iast (9.587 ms) : 9420, 9754
. : milestone, 9587,
iast_FULL (13.72 ms) : 13448, 13992
. : milestone, 13720,
iast_GLOBAL (9.89 ms) : 9719, 10060
. : milestone, 9890,
profiling (9.432 ms) : 9260, 9604
. : milestone, 9432,
tracing (7.381 ms) : 7278, 7484
. : milestone, 7381,
section candidate
no_agent (4.317 ms) : 4268, 4366
. : milestone, 4317,
iast (9.369 ms) : 9219, 9519
. : milestone, 9369,
iast_FULL (14.031 ms) : 13757, 14305
. : milestone, 14031,
iast_GLOBAL (10.221 ms) : 10026, 10417
. : milestone, 10221,
profiling (8.7 ms) : 8560, 8841
. : milestone, 8700,
tracing (7.609 ms) : 7494, 7724
. : milestone, 7609,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 2 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.51.1-SNAPSHOT~31e2345148, baseline=1.51.1-SNAPSHOT~6b55bdc9d0
dateFormat X
axisFormat %s
section baseline
no_agent (14.955 s) : 14955000, 14955000
. : milestone, 14955000,
appsec (14.669 s) : 14669000, 14669000
. : milestone, 14669000,
iast (18.975 s) : 18975000, 18975000
. : milestone, 18975000,
iast_GLOBAL (17.946 s) : 17946000, 17946000
. : milestone, 17946000,
profiling (15.234 s) : 15234000, 15234000
. : milestone, 15234000,
tracing (14.963 s) : 14963000, 14963000
. : milestone, 14963000,
section candidate
no_agent (15.099 s) : 15099000, 15099000
. : milestone, 15099000,
appsec (14.892 s) : 14892000, 14892000
. : milestone, 14892000,
iast (18.706 s) : 18706000, 18706000
. : milestone, 18706000,
iast_GLOBAL (18.106 s) : 18106000, 18106000
. : milestone, 18106000,
profiling (15.467 s) : 15467000, 15467000
. : milestone, 15467000,
tracing (14.971 s) : 14971000, 14971000
. : milestone, 14971000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.51.1-SNAPSHOT~31e2345148, baseline=1.51.1-SNAPSHOT~6b55bdc9d0
dateFormat X
axisFormat %s
section baseline
no_agent (1.478 ms) : 1466, 1489
. : milestone, 1478,
appsec (2.414 ms) : 2365, 2463
. : milestone, 2414,
iast (2.206 ms) : 2143, 2268
. : milestone, 2206,
iast_GLOBAL (2.251 ms) : 2189, 2314
. : milestone, 2251,
profiling (2.489 ms) : 2320, 2658
. : milestone, 2489,
tracing (2.015 ms) : 1967, 2063
. : milestone, 2015,
section candidate
no_agent (1.48 ms) : 1468, 1492
. : milestone, 1480,
appsec (3.701 ms) : 3482, 3920
. : milestone, 3701,
iast (2.205 ms) : 2143, 2267
. : milestone, 2205,
iast_GLOBAL (2.246 ms) : 2184, 2309
. : milestone, 2246,
profiling (2.037 ms) : 1987, 2086
. : milestone, 2037,
tracing (2.02 ms) : 1972, 2068
. : milestone, 2020,
|
…in); update tests for new structure
…his in getString method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
Motivation
Additional Notes
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]