-
Notifications
You must be signed in to change notification settings - Fork 311
Report all set configuration sources to telemetry #9273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
a31cb1b
View all sources in getString
mtoffl01 0ea5afb
fix getString logic to use the first found value
mtoffl01 f459280
Apply logic to other getString* methods and get method
mtoffl01 5207180
Refactor ConfigCollector to store latest ConfigSetting per (key, orig…
mtoffl01 27f6205
remove superfluous logs
mtoffl01 844db66
Javadoc
mtoffl01 31e2345
Introduce seqID field to ConfigSettings and have ConfigProvider set t…
mtoffl01 43109aa
Use precedence field on ConfigOrigin to determine seq_id
mtoffl01 6fd9a05
Update TelemetryRequestBodySpecification tests for seq_id
mtoffl01 e8701e4
Fix more TelemetryServiceSpecification tests
mtoffl01 f999b4d
nits/cleanup
mtoffl01 c698d29
Register sources on configprovider in lowest to highest precedence
mtoffl01 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NOTE!
Previously this method invoked
collect()
on the ConfigCollector;collect()
drains the collector, which seems at odds with the expected behavior ofgetLogInjectionEnabled()
—a method that, based on its name, should simply read a value rather than mutate or clear state.Is
getLogInjectionEnabled()
supposed to trigger a collection cycle? If so — why? But also, we just have to call collect() manually here as well.