-
Notifications
You must be signed in to change notification settings - Fork 1.2k
LLM obs Java SDK #30524
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LLM obs Java SDK #30524
Conversation
✅ Documentation Team ReviewThe documentation team has approved this pull request. Thank you for your contribution! |
Preview links (active after the
|
added DOCS-11546 to review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!! Thank you so much Cecilia for the quick turnaround and the accuracy of the docs!!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few minor fixes and then a handful of suggestions -- take or leave what you wish!
Let me know when ready for another look :)
--- | ||
|
||
## Overview | ||
|
||
Datadog's LLM Observability SDK for enhances the observability of your LLM applications. The SDK supports Python versions 3.7 and newer. | ||
Datadog's LLM Observability SDK for enhances the observability of your LLM applications. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there's a missing word here after "for"? Or maybe "for" can be removed?
@@ -49,6 +52,14 @@ For usage examples you can run from a Jupyter notebook, see the [LLM Observabili | |||
|
|||
[1]: https://app.datadoghq.com/organization-settings/api-keys | |||
{{% /tab %}} | |||
|
|||
{{% tab "Java" %}} | |||
- You have downloaded the latest [`dd-trace-java` JAR][1]. The LLM Observability SDK is supported in `dd-trace-java` v1.51.0+. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very much a nit, but noting that this tense is inconsistent with the other tabs, which follow the form "Blahdiblah is installed" vs "You have installed".
|
||
`DD_SITE` | ||
: required - _string_ | ||
<br />The Datadog site to submit your LLM data. Your site is {{< region-param key="dd_site" code="true" >}}. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if this is the best rework but trying to avoid the dangling preposition of "The Datadog site to submit your LLM data to" and the awkwardness of "The Datadog site to which to submit your LLM data."
<br />The Datadog site to submit your LLM data. Your site is {{< region-param key="dd_site" code="true" >}}. | |
<br />Destination Datadog site for LLM data submission. Your site is {{< region-param key="dd_site" code="true" >}}. |
|
||
`DD_SITE` or `dd.site` | ||
: required - _string_ | ||
<br />The Datadog site to submit your LLM data. Your site is {{< region-param key="dd_site" code="true" >}}. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<br />The Datadog site to submit your LLM data. Your site is {{< region-param key="dd_site" code="true" >}}. | |
<br />Destination Datadog site for LLM data. Your site is {{< region-param key="dd_site" code="true" >}}. |
|
||
### Starting a span | ||
|
||
There are several different methods to start a span, based on the kind of span that you are starting. See the [Span Kinds documentation][1] for a list of supported span kinds. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are several different methods to start a span, based on the kind of span that you are starting. See the [Span Kinds documentation][1] for a list of supported span kinds. | |
There are several methods to start a span, based on the kind of span that you are starting. See the [Span Kinds documentation][1] for a list of supported span kinds. |
: required - `CharSequence` | ||
<br /> The name of the metric | ||
|
||
`value` | ||
: required - `int`, `long`, or `double` | ||
<br /> The value of the metric |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
: required - `CharSequence` | |
<br /> The name of the metric | |
`value` | |
: required - `int`, `long`, or `double` | |
<br /> The value of the metric | |
: required - `CharSequence` | |
<br /> The name of the metric. | |
`value` | |
: required - `int`, `long`, or `double` | |
<br /> The value of the metric. |
<br /> The key of the tag | ||
|
||
`value` | ||
: required - `int`, `long`, `double`, `boolean`, or `String` | ||
<br /> The value of the tag |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<br /> The key of the tag | |
`value` | |
: required - `int`, `long`, `double`, `boolean`, or `String` | |
<br /> The value of the tag | |
<br /> The key of the tag. | |
`value` | |
: required - `int`, `long`, `double`, `boolean`, or `String` | |
<br /> The value of the tag. |
|
||
`errorMessage` | ||
: required - `String` | ||
<br /> The message of the error |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<br /> The message of the error | |
<br /> The message of the error. |
|
||
`error` | ||
: required - `boolean` | ||
<br /> `true` if the span errored |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<br /> `true` if the span errored | |
<br /> `true` if the span errored. |
|
||
`tags` | ||
: optional - `Map<String, Object>` | ||
<br />A dictionary of string key-value pairs that users can add as tags regarding the evaluation. For more information about tags, see [Getting Started with Tags][3]. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<br />A dictionary of string key-value pairs that users can add as tags regarding the evaluation. For more information about tags, see [Getting Started with Tags][3]. | |
<br />A dictionary of string key-value pairs used to tag the evaluation. For more information about tags, see [Getting Started with Tags][1]. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a suggestion to fix one typo but otherwise looks good!
Co-authored-by: domalessi <[email protected]>
What does this PR do? What is the motivation?
Merge instructions
Merge readiness:
For Datadog employees:
Your branch name MUST follow the
<name>/<description>
convention and include the forward slash (/
). Without this format, your pull request will not pass CI, the GitLab pipeline will not run, and you won't get a branch preview. Getting a branch preview makes it easier for us to check any issues with your PR, such as broken links.If your branch doesn't follow this format, rename it or create a new branch and PR.
[6/5/2025] Merge queue has been disabled on the documentation repo. If you have write access to the repo, the PR has been reviewed by a Documentation team member, and all of the required checks have passed, you can use the Squash and Merge button to merge the PR. If you don't have write access, or you need help, reach out in the #documentation channel in Slack.
Additional notes