Skip to content

load SDS rules from API via websites-sources-[DOCSENG-79] #30843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Aug 13, 2025

Conversation

StefonSimmons
Copy link
Contributor

@StefonSimmons StefonSimmons commented Jul 31, 2025

What does this PR do? What is the motivation?

load Senstive Data Scanner rules from Datadog API via websites-sources

  • use multifilter-search component for filter and search functionality
  • update component to utilize JSON from /data directory

motivation: https://datadoghq.atlassian.net/jira/software/projects/DOCSENG/boards/10954?selectedIssue=DOCSENG-79
preview: https://docs-staging.datadoghq.com/stefon.simmons/docseng-79-sds/security/sensitive_data_scanner/scanning_rules/library_rules/#overview

  • check that you can search and filter page content
  • this preview build uses main branch of websites-sources (websites-sources@main)

Merge instructions

Merge readiness:

  • Ready for merge

For Datadog employees:

Your branch name MUST follow the <name>/<description> convention and include the forward slash (/). Without this format, your pull request will not pass CI, the GitLab pipeline will not run, and you won't get a branch preview. Getting a branch preview makes it easier for us to check any issues with your PR, such as broken links.

If your branch doesn't follow this format, rename it or create a new branch and PR.

[6/5/2025] Merge queue has been disabled on the documentation repo. If you have write access to the repo, the PR has been reviewed by a Documentation team member, and all of the required checks have passed, you can use the Squash and Merge button to merge the PR. If you don't have write access, or you need help, reach out in the #documentation channel in Slack.

Additional notes

@github-actions github-actions bot added the Architecture Everything related to the Doc backend label Jul 31, 2025
Copy link
Contributor

github-actions bot commented Jul 31, 2025

✅ Documentation Team Review

The documentation team has approved this pull request. Thank you for your contribution!

@StefonSimmons StefonSimmons changed the title load sds rules from API via websites-sources load sds rules from API via websites-sources-[DOCSENG-79] Jul 31, 2025
@StefonSimmons StefonSimmons changed the title load sds rules from API via websites-sources-[DOCSENG-79] load SDS rules from API via websites-sources-[DOCSENG-79] Jul 31, 2025
Copy link
Contributor

github-actions bot commented Jul 31, 2025

Preview links (active after the build_preview check completes)

Modified Files

@github-actions github-actions bot added Github Related to Github configurations Images Images are added/removed with this PR Guide Content impacting a guide and removed Github Related to Github configurations Images Images are added/removed with this PR Guide Content impacting a guide labels Aug 12, 2025
@StefonSimmons StefonSimmons force-pushed the stefon.simmons/docseng-79-sds branch from 1768fd7 to 36d1ed4 Compare August 12, 2025 18:03
@StefonSimmons StefonSimmons marked this pull request as ready for review August 12, 2025 18:21
@StefonSimmons StefonSimmons requested review from a team as code owners August 12, 2025 18:21
Copy link
Contributor

@maycmlee maycmlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you!

@StefonSimmons StefonSimmons merged commit 09ff568 into master Aug 13, 2025
23 checks passed
@StefonSimmons StefonSimmons deleted the stefon.simmons/docseng-79-sds branch August 13, 2025 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Architecture Everything related to the Doc backend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants