DYN-8972: Disable data collection agreements in NoNetworkMode

[kalunkuo]

Purpose

• Disable data collection agreements in NoNetworkMode
• Added a NoNetworkMode check to the UsageReportingManager.CheckIsFirstRun() method
• Modify HideReportOptions logic to include NoNetworkMode condition

Testing

• Verified no data collection dialog appears in no-network mode
• Confirmed normal mode still shows dialog as expected
• Tested with --NoNetworkMode command line argument

Declarations

Check these if you believe they are true

• Is documented according to the standards
• The level of testing this PR includes is appropriate
• Changes to the API follow Semantic Versioning and are documented in the API Changes document.

Release Notes

Ensures no-network mode disable the terms of use (data agreement) dialog at startup

Reviewers

@DynamoDS/eidos @DynamoDS/synapse

[Copilot]

Pull Request Overview

This PR disables data collection agreements in no-network mode by adding a check to prevent the usage reporting dialog from appearing when Dynamo is running with network access disabled.

• Added NoNetworkMode check to prevent data collection dialog in no-network mode
• Maintains existing behavior for normal mode operation

[github-actions]

See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-8972

[zeusongit]

I think NoNetwork mode can be enabled even if it is not the First Run, and we should catch those cases as well. Is this the only place we trigger ShowUsageReportingPrompt() ?

[kalunkuo]

I think NoNetwork mode can be enabled even if it is not the First Run, and we should catch those cases as well. Is this the only place we trigger ShowUsageReportingPrompt() ?

Good call @zeusongit ! ShowUsageReportingPrompt() is also triggered here

        public void ToggleIsAnalyticsReportingApproved(object parameter)
        {
            var ownerWindow = parameter as Window;
            if (ownerWindow == null)
            {
                throw new InvalidOperationException(
                    "DynamoView must be supplied for this command");
            }
            ShowUsageReportingPrompt(ownerWindow);
        }

[kalunkuo]

I added the MessageBox:

[zavub]

Perhaps we could simply not show the toggle at all in Dynamo view ? Otherwise I assume this message will need to be localized.

[kalunkuo]

Good idea!

[aparajit-pratap]

I added the MessageBox:

I do not see any code for this message box 😕

[kalunkuo]

I added the MessageBox:

I do not see any code for this message box 😕

@aparajit-pratap I removed it after seeing @zavub's yesterday. Currently, it is not show the toggle at all in Dynamo view if in NoNetworkMode:

[aparajit-pratap]

I added the MessageBox:

I do not see any code for this message box 😕

@aparajit-pratap I removed it after seeing @zavub's yesterday. Currently, it is not show the toggle at all in Dynamo view if in NoNetworkMode:

I don't get it, what toggle?