Skip to content

DYN-8972: Disable data collection agreements in NoNetworkMode #16534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Oct 1, 2025
Merged

DYN-8972: Disable data collection agreements in NoNetworkMode #16534

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
439eafa
DYN-8972: Disable data collection agreements in NoNetworkMode
kalunkuo Sep 29, 2025
99977c7
Small fix
kalunkuo Sep 29, 2025
0498902
Add NoNetWorkCheck to ToggleIsAnalyticsReportingApproved()
kalunkuo Sep 29, 2025
d9b84a3
Add NoNetWorkCheck to ToggleIsAnalyticsReportingApproved()
kalunkuo Sep 29, 2025
500a69b
Hide analytics toggle in no-network mode instead of showing message
kalunkuo Sep 29, 2025
bef0094
Merge branch 'master' into DYN-8972
kalunkuo Sep 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/DynamoCoreWpf/Services/UsageReportingManager.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,8 @@ public void CheckIsFirstRun(Window ownerWindow, IBrandingResourceProvider resour
&& dynamoViewModel.Model.PreferenceSettings.IsFirstRun
&& !dynamoViewModel.HideReportOptions
&& !Analytics.DisableAnalytics
&& !DynamoModel.IsTestMode)
&& !DynamoModel.IsTestMode
&& !dynamoViewModel.Model.NoNetworkMode)
{
//Prompt user for detailed reporting
ShowUsageReportingPrompt(ownerWindow);
Expand All @@ -99,6 +100,7 @@ public void ToggleIsAnalyticsReportingApproved(object parameter)
throw new InvalidOperationException(
"DynamoView must be supplied for this command");
}

ShowUsageReportingPrompt(ownerWindow);
}

Expand Down
2 changes: 1 addition & 1 deletion src/DynamoCoreWpf/ViewModels/Core/DynamoViewModel.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -793,7 +793,7 @@ protected DynamoViewModel(StartConfiguration startConfiguration)
this.model.CommandCompleted += OnModelCommandCompleted;
this.model.RequestsCrashPrompt += CrashReportTool.ShowCrashWindow;

this.HideReportOptions = startConfiguration.HideReportOptions;
this.HideReportOptions = startConfiguration.HideReportOptions || model.NoNetworkMode;
UsageReportingManager.Instance.InitializeCore(this);
this.WatchHandler = startConfiguration.WatchHandler;
var pmExtension = model.GetPackageManagerExtension();
Expand Down
Loading