(docs-adjacent) Update PR template - #875
Conversation
|
Obviously, you call can change the comments, etc. to whatever works best for swell in terms of labels, tests... |
| <!--- 0 diff structural: this change only moves code around --> | ||
| <!--- 0 diff: this change is to code and has no impact on the results --> | ||
| <!--- non 0-diff: this change affects the results --> | ||
| - [ ] I have tested this change with a run of SWELL suite (if non-trivial), see documentation xxx for testing details |
There was a problem hiding this comment.
Another checkpoint for adding documentation? Something like
| - [ ] I have tested this change with a run of SWELL suite (if non-trivial), see documentation xxx for testing details | |
| - [ ] I have tested this change with a run of SWELL suite (if non-trivial) | |
| - [ ] I have added or updated the documentation to describe my new feature |
There was a problem hiding this comment.
Good idea, I will change it once the sidebar is finalized.
|
I like it, I guess we'll need to add the new labels this references. Maybe we could also push people to use the existing labels (atmosphere DA, observations, compo, documentation etc.). I know I could definitely be better about this |
@mranst You can use a label enforcer as well if you have labels you require (see https://github.com/GEOS-ESM/GEOSgcm/blob/main/.github/workflows/enforce-labels.yml for an example) |
4 participants
I copied @mathomp4's PR:
https://github.com/GEOS-ESM/GEOSgcm_GridComp/pull/739/changes
I think overall this is a good structure but we can be descriptive in terms expectations on the user for tier testing and define different labels?