-
Notifications
You must be signed in to change notification settings - Fork 7
(docs-adjacent) Update PR template #875
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Dooruk
wants to merge
1
commit into
develop
Choose a base branch
from
git/update_pull_request_template
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,13 +1,43 @@ | ||
| <!--- These lines are comments. You can delete or ignore them --> | ||
| <!--- NOTE: If your PR is trivial, feel free to delete the "Related Issue" --> | ||
| <!--- "Testing" or other sections. --> | ||
|
|
||
| <!--- Provide a brief summary of your changes in the Title above --> | ||
|
|
||
| ## Description | ||
| <!--- Describe your changes in detail --> | ||
|
|
||
| ## Related Issue | ||
| <!--- This project primarily accepts pull requests related to open issues --> | ||
| <!--- If suggesting a new feature, observer, or change, please discuss it in an issue first --> | ||
| <!--- If fixing a bug, there should be an issue describing it with steps to reproduce --> | ||
| <!--- Please add the issue number below or delete the Closes line if this is not relevant --> | ||
|
|
||
| *Provide a detailed description of what this PR does.* | ||
| Closes # | ||
|
|
||
| ## Dependencies | ||
| ## Motivation and Context | ||
| <!--- (Optional) Why is this change required? What problem does it solve? --> | ||
|
|
||
| - [ ] waiting on GEOS-ESM/repo/pull/<pr_number> | ||
| - [ ] waiting on GEOS-ESM/repo/pull/<pr_number> | ||
| ## How Has This Been Tested? | ||
| <!--- Please describe in detail how you tested your changes. --> | ||
| <!--- Include details of your testing environment, and the tests you ran to --> | ||
| <!--- see how your change affects other areas of the code, etc. --> | ||
|
|
||
| ## Impact | ||
| ## Types of changes | ||
| <!--- What types of changes does your code introduce? --> | ||
| <!--- Put an `x` in all the boxes that apply so that it looks like [x] --> | ||
| - [ ] Bug fix (non-breaking change which fixes an issue) | ||
| - [ ] New feature (non-breaking change which adds functionality) | ||
| - [ ] Breaking change (fix or feature that would cause existing functionality to change) | ||
| - [ ] Trivial change (affects only documentation or cleanup) | ||
|
|
||
| - [ ] repo | ||
| - [ ] ... | ||
| ## Checklist: | ||
| <!--- Go over all the following points, and put an `x` in all the boxes that apply. --> | ||
| <!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> | ||
| <!--- For the required labels: --> | ||
| <!--- 0 diff trivial: this change is to documentation or obviously does not affect the results --> | ||
| <!--- 0 diff structural: this change only moves code around --> | ||
| <!--- 0 diff: this change is to code and has no impact on the results --> | ||
| <!--- non 0-diff: this change affects the results --> | ||
| - [ ] I have tested this change with a run of SWELL suite (if non-trivial), see documentation xxx for testing details | ||
| - [ ] I have added one of the required labels (0 diff, 0 diff trivial, 0 diff structural, non 0-diff) | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another checkpoint for adding documentation? Something like
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea, I will change it once the sidebar is finalized.