Merge with upstream repo (and fix subsetting!) #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added `defaultLanguage` to font objects Setting the defaultLanguage allows you to overwrite the language returned by property getters like `fullName`, `familyName`, etc * Look up `postscriptName` by the `defaultLanguage`
…d of only enabled) (foliojs#206)
Bumps [lodash](https://github.com/lodash/lodash) from 4.17.4 to 4.17.15. - [Release notes](https://github.com/lodash/lodash/releases) - [Commits](lodash/lodash@4.17.4...4.17.15) Signed-off-by: dependabot[bot] <[email protected]>
* Fix FDArray parsing in CFF * run test only if font available
|
Hi @Hopding, I'm sure a lot of people would appreciate this being merged, could you take a look when you have a moment? Thanks. |
|
Yes, I'd be one of those people! |
2 tasks
|
Any update on this? |
1 similar comment
|
Any update on this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👋 Hopding
This PR brings in all upstream changes from
foliojs/fontkit.Specifically interesting is the commit 'Fix saving loca index format/version when subsetting' (Upstream PR)
As it appears to fix the longstanding issue with
{ subset: true }in pdf-lib.