Add ibm_pi_volumes data source and fix ibm_pi_volume data source to use id #6508
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ismirlia
requested review from
hkantare,
kavya498,
omaraibrahim and
uibm
as code owners
michaelkad
force-pushed
the
volume-data-sources
branch
from
38c70d7 to
1857b1c
Compare
yussufsh
reviewed
Oct 16, 2025
ismirlia
force-pushed
the
volume-data-sources
branch
from
4155ae4 to
59cf74b
Compare
|
@yussufsh I rebased this PR and opened another for ibm_pi_volumes data source. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request deprecates name fields for id fields. In either case (before and after this change), the user can put either the name or id and resource will be fetched. The reason for this change is that APP Config team is fetching tons of resources and sometimes if you use the name the cache could fail or fetch stale data. The ID is more reliable. This change is to encourage the user to use IDs instead of names.
Output of acceptance testing: