Skip to content

refactor: reduce filter param duplication #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
AlexanderNZ wants to merge 1 commit into
base: main
Choose a base branch
from
Open

refactor: reduce filter param duplication #19

AlexanderNZ wants to merge 1 commit into from

Conversation

@AlexanderNZ
Copy link
Contributor

@AlexanderNZ AlexanderNZ commented Jan 29, 2026 •
edited
Loading

Here’s a small cleanup I made so the filter query logic lives in one place.

What I changed

  • pulled the filter-to-querystring logic into a shared helper
  • updated the IcePanel client methods to use that helper

Why I did it

  • it was the same logic repeated in several places
  • a single helper makes future tweaks safer and easier to review

Test plan

  • not run (refactor only)

Recommended merge order

@AlexanderNZ
refactor: extract buildFilterParams helper to reduce duplication
f06e7aa 
The filter-to-URLSearchParams conversion logic was duplicated 4 times
across getCatalogTechnologies, getOrganizationTechnologies,
getModelObjects, and getModelConnections.

This extracts a buildFilterParams helper function that handles:
- Array values
- Null values
- Labels objects
- Simple string/boolean values
This was referenced Jan 29, 2026
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@AlexanderNZ