Skip to content

Conversation

@AlexanderNZ
Copy link
Contributor

@AlexanderNZ AlexanderNZ commented Jan 29, 2026

I updated the docs and read tests to match the new read endpoints.

What I changed

  • documented the new read tools in the README
  • added integration tests for tags, domains, connections, diagrams, flows, and exports

Why I did it

  • the README should match what the server actually exposes
  • tests make sure the new reads work end-to-end

Notes

Test plan

  • not run

Note

Low Risk
Low risk: changes are limited to documentation and new integration tests; no server/runtime logic is modified.

Overview
Updates README.md with a clearer Quick Start, stdio vs Streamable HTTP client configuration, a full reference list of icepanel_* read/write tools (including v0.3.0 naming/pagination), plus environment variables, CLI flags, Docker, and integration test setup.

Adds tests/read-tools.int.test.ts, an integration suite that conditionally runs with credentials and exercises the expanded read tool surface (tags/domains/connections/diagrams/flows, thumbnails, and CSV/JSON exports) against a real IcePanel org.

Written by Cursor Bugbot for commit 05358b8. This will update automatically on new commits. Configure here.

Recommended merge order

Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.

baseUrl = started.baseUrl;
closeServer = started.close;

landscapeId = await resolveLandscapeId(baseUrl, TARGET_LANDSCAPE_NAME || "");
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TARGET_LANDSCAPE_ID is declared but never used

Medium Severity

The TARGET_LANDSCAPE_ID variable is read from the environment and checked in the guard clause (line 26), but resolveLandscapeId on line 37 only uses TARGET_LANDSCAPE_NAME, passing an empty string if it's undefined. If a user follows the README and provides only ICEPANEL_MCP_TEST_LANDSCAPE_ID, the test will fail because the ID is never passed to the resolver. Similarly, line 59 passes a potentially undefined TARGET_LANDSCAPE_NAME to normalizeNameForTest.

Additional Locations (1)

Fix in Cursor Fix in Web

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant