Skip to content

Conversation

@lwin-kyaw
Copy link
Contributor

@lwin-kyaw lwin-kyaw commented Nov 24, 2025

Description

Enable metrics toggle in settings after shield subscription.

Open in GitHub Codespaces

Changelog

CHANGELOG entry: enabled metametrics toggle for active shield subscribers

Related issues

Fixes: #38178

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Enables the MetaMetrics toggle regardless of Shield subscription, disabling it only when external services are off.

  • Settings UI (ui/pages/settings/security-tab/metametrics-toggle/metametrics-toggle.tsx):
    • Enable MetaMetrics toggle independent of Shield subscription by removing getIsActiveShieldSubscription usage and the disableMetametricsToggle logic.
    • ToggleButton disabled now depends only on !useExternalServices.
    • Minor cleanup: removed unused selector import and related variables.

Written by Cursor Bugbot for commit 5120bab. This will update automatically on new commits. Configure here.

@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-onboarding Onboarding team label Nov 24, 2025
@lwin-kyaw lwin-kyaw added release-blocker This bug is blocking the next release release-13.11.0 Issue or pull request that will be included in release 13.11.0 labels Nov 24, 2025
@metamaskbot
Copy link
Collaborator

Builds ready [5120bab]
UI Startup Metrics (1204 ± 114 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyStandard HomeuiStartup12041001156411412591462
load1020848132110110771235
domContentLoaded1013834130910010711225
domInteractive27151292621109
firstPaint64376131741710341186
backgroundConnect2111902539215226
firstReactRender27195593147
getState301580103451
initialActions107112
loadScripts8096461121998671009
setupStore1052431118
numNetworkReqs1257821574
BrowserifyPower User HomeuiStartup18661571240818319812241
load100386816301579961487
domContentLoaded98886316231569791471
domInteractive39172694731180
firstPaint5548715183849451219
backgroundConnect22319526312228249
firstReactRender82461381791109
getState17112426929189235
initialActions109114
loadScripts78167114201557701257
setupStore211078112344
numNetworkReqs1436429952181269
WebpackStandard HomeuiStartup8146911113908301056
load63556391274665825
domContentLoaded63055990473656818
domInteractive28141152622108
firstPaint23695852175208678
backgroundConnect1052941217
firstReactRender27196683146
getState2813100153755
initialActions104111
loadScripts62755789572653810
setupStore1063041216
numNetworkReqs1257721573
WebpackPower User HomeuiStartup14311224205915715441679
load6715881239117665985
domContentLoaded6615811233118651979
domInteractive42172874832171
firstPaint256102681158237623
backgroundConnect1576381527
firstReactRender82421111490102
getState15012619114159179
initialActions104112
loadScripts6585791221116649971
setupStore21952132450
numNetworkReqs1466433655185293
FirefoxBrowserifyStandard HomeuiStartup12241065157411212691477
load102791012908410731186
domContentLoaded102690912908410731186
domInteractive58272584081138
firstPaint------
backgroundConnect3821146234292
firstReactRender23184862336
getState126144151124
initialActions102012
loadScripts100389612447610511161
setupStore1155071225
numNetworkReqs1156415662
BrowserifyPower User HomeuiStartup24551944321227426493025
load1133951164716011331508
domContentLoaded1132951164716011331507
domInteractive12735643114114435
firstPaint------
backgroundConnect1102661697120313
firstReactRender86391682599128
getState26161861216349765
initialActions2128327
loadScripts1092927161314310951467
setupStore13912786183133617
numNetworkReqs92632204379208
WebpackStandard HomeuiStartup15421329289717915681832
load13031097265316313281483
domContentLoaded13021097265216313271482
domInteractive8928142213985136
firstPaint------
backgroundConnect47181422450106
firstReactRender30237283142
getState1175161222
initialActions103122
loadScripts12741082263516013011433
setupStore156177211163
numNetworkReqs1156916663
WebpackPower User HomeuiStartup25922100318526027213149
load13461080180219815231739
domContentLoaded13451080180219815231739
domInteractive10929477105103392
firstPaint------
backgroundConnect932244171107252
firstReactRender80421571888117
getState25565879217352709
initialActions309227
loadScripts13111058176319414831696
setupStore1156749162122541
numNetworkReqs915920436110164
📊 Page Load Benchmark Results

Current Commit: 5120bab | Date: 11/24/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.01s (±49ms) 🟡 | historical mean value: 1.04s ⬇️ (historical data)
  • domContentLoaded-> current mean value: 700ms (±45ms) 🟢 | historical mean value: 725ms ⬇️ (historical data)
  • firstContentfulPaint-> current mean value: 79ms (±12ms) 🟢 | historical mean value: 78ms ⬆️ (historical data)

📈 Detailed Results

Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.01s 49ms 978ms 1.36s 1.05s 1.36s
domContentLoaded 700ms 45ms 670ms 1.02s 729ms 1.02s
firstPaint 79ms 12ms 64ms 168ms 88ms 168ms
firstContentfulPaint 79ms 12ms 64ms 168ms 88ms 168ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 53 Bytes (0%)
  • ui: -140 Bytes (0%)
  • common: 20 Bytes (0%)

@lwin-kyaw lwin-kyaw added this pull request to the merge queue Nov 24, 2025
Merged via the queue into main with commit 4f66469 Nov 24, 2025
349 of 357 checks passed
@lwin-kyaw lwin-kyaw deleted the fix/metrics-toggle-disabled-after-shield branch November 24, 2025 15:03
@github-actions github-actions bot locked and limited conversation to collaborators Nov 24, 2025
@metamaskbot metamaskbot added the release-13.12.0 Issue or pull request that will be included in release 13.12.0 label Nov 24, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-13.11.0 Issue or pull request that will be included in release 13.11.0 release-13.12.0 Issue or pull request that will be included in release 13.12.0 release-blocker This bug is blocking the next release team-onboarding Onboarding team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Metametrics toggle is disabled after the shield subscription.

6 participants