Skip to content

fix: enabled metrics toggle after shield subs cp-13.11.0 #38176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 24, 2025
+1 −6
Merged

fix: enabled metrics toggle after shield subs cp-13.11.0 #38176

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions ui/pages/settings/security-tab/metametrics-toggle/metametrics-toggle.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@ import {
getParticipateInMetaMetrics,
getUseExternalServices,
} from '../../../../selectors';
import { getIsActiveShieldSubscription } from '../../../../selectors/subscription';

const MetametricsToggle = ({
dataCollectionForMarketing,
Expand All @@ -49,10 +48,6 @@ const MetametricsToggle = ({
const isBackupAndSyncEnabled = useSelector(selectIsBackupAndSyncEnabled);
const participateInMetaMetrics = useSelector(getParticipateInMetaMetrics);
const useExternalServices = useSelector(getUseExternalServices);
const isActiveShieldSubscription = useSelector(getIsActiveShieldSubscription);
// we will enable the metametrics option if the user has a shield subscription and user can't toggle the metametrics option with active shield subscription
const disableMetametricsToggle =
isActiveShieldSubscription || !useExternalServices;

const handleUseParticipateInMetaMetrics = async (isParticipated: boolean) => {
if (isParticipated) {
Expand Down Expand Up @@ -121,7 +116,7 @@ const MetametricsToggle = ({
>
<ToggleButton
value={participateInMetaMetrics}
disabled={disableMetametricsToggle}
disabled={!useExternalServices}
onToggle={(value) => handleUseParticipateInMetaMetrics(!value)}
offLabel={t('off')}
onLabel={t('on')}
Expand Down
Loading