Hotfix/missing cpr #214
Open
Hotfix/missing cpr #214
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stankut
reviewed
Sep 15, 2025
| if (!$cprLookupResult->isSuccessful()) { | ||
| return $response; | ||
| } | ||
|
|
There was a problem hiding this comment.
i would suggest to put the return right after the initialization, if the result is not successful
or else that can be combined with the IF statement we already have:
something like:
if ($cprPlugin->isReady() && $cprLookupResult = $cprPlugin->lookup($childCpr)) {
stankut
requested changes
Sep 15, 2025
ds-bellcom
added
the
Incl. in the next release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #218
Prevent further action in MitidChildrenSelectAjaxBehaviour.php if no cpr is found.