Skip to content

Hotfix/missing cpr #214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Hotfix/missing cpr #214

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
958519a
Added handling for missing cpr in MitidChildrenSelectAjaxBehaviour
martinyde Aug 26, 2025
aab157d
Modified changelog
martinyde Aug 26, 2025
37de1f7
Updated changelog
martinyde Sep 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@ before starting to add changes. Use example [placed in the end of the page](#exa

## [Unreleased]

- [192](https://github.com/OS2Forms/os2forms/pull/192)
Fix bug in MitidChildrenSelectAjaxBehaviour.php
- [PR-101](https://github.com/OS2Forms/os2forms/pull/101)
- Added support for `os2web_key` in Digital post
- Switched from saving settings in key value store to config, i.e
Expand Down
4 changes: 4 additions & 0 deletions modules/os2forms_nemid/src/Element/MitidChildrenSelectAjaxBehaviour.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,10 @@ public static function mitidChildrenSelectAjax(array &$form, FormStateInterface
$webform = $webformSubmission->getWebform();
$elementsFlattened = $webform->getElementsInitializedAndFlattened();

if (!$cprLookupResult->isSuccessful()) {
return $response;
}

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i would suggest to put the return right after the initialization, if the result is not successful

os2forms/modules/os2forms_nemid/src/Element/MitidChildrenSelectAjaxBehaviour.php

Line 47 in 37de1f7

or else that can be combined with the IF statement we already have:

os2forms/modules/os2forms_nemid/src/Element/MitidChildrenSelectAjaxBehaviour.php

Line 45 in 37de1f7

if ($cprPlugin->isReady()) {

something like:
if ($cprPlugin->isReady() && $cprLookupResult = $cprPlugin->lookup($childCpr)) {

foreach ($elementsFlattened as $flattenedElement) {
if (isset($flattenedElement['#type'])) {
$parents = $flattenedElement['#webform_parents'];
Expand Down
Loading