Skip to content

Upgrade Biome to Newest Major Version #187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 22, 2025
Merged

Upgrade Biome to Newest Major Version #187

merged 4 commits into from
Jul 22, 2025

Conversation

emnul
Copy link
Contributor

@emnul emnul commented Jul 22, 2025

Types of changes

What types of changes does your code introduce to OpenZeppelin Midnight Contracts?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Closes #150

This pull request migrates biome.json to be compatible with the newest major version and upgrades the biome package to v2.1.2

Additionally, it organizes package imports in our TS files and refactors some legacy biome-ignore comments to work with the newest version

This PR also addresses #142 without having to ignore all package.json files.

Note according to the biome v2 docs VS Code extension v3 needs complete restart

PR Checklist

@emnul emnul requested a review from a team as a code owner July 22, 2025 00:35
@emnul emnul self-assigned this Jul 22, 2025
Copy link
Contributor

@andrew-fleming andrew-fleming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@emnul emnul merged commit 8c847a6 into main Jul 22, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade Biome to Newest Major Version
2 participants