Upgrade Biome to Newest Major Version

biome.json

@@ -1,5 +1,5 @@
 {
-  "$schema": "https://biomejs.dev/schemas/1.9.4/schema.json",
+  "$schema": "https://biomejs.dev/schemas/2.1.2/schema.json",
   "vcs": {
     "enabled": true,
     "clientKind": "git",
@@ -8,31 +8,34 @@
   },
   "files": {
     "ignoreUnknown": false,
-    "ignore": [
-      "tsconfig.base.json",
-      "tsconfig*.json",
-      "*.compact",
-      "artifacts/*",
-      "coverage/*",
-      "dist/*",
-      "reports/*"
+    "includes": [
+      "**",
+      "!**/tsconfig.base.json",
+      "!**/tsconfig*.json",
+      "!**/*.compact",
+      "!**/artifacts/**/*",
+      "!**/coverage/**/*",
+      "!**/dist/**/*",
+      "!**/reports/**/*"
     ]
   },
   "formatter": {
     "enabled": true,
     "indentStyle": "space",
-    "ignore": ["package.json"]
+    "includes": ["**"]
   },
-  "organizeImports": {
-    "enabled": true
+  "assist": {
+    "actions": {
+      "source": {
+        "organizeImports": "on"
+      }
+    }
   },
   "linter": {
     "enabled": true,
     "rules": {
       "recommended": true,
-      "a11y": {
-        "all": false
-      },
+      "a11y": {},
       "correctness": {
         "noUnusedVariables": "error",
         "noUnusedImports": "error",
@@ -56,12 +59,26 @@
       },
       "style": {
         "noNonNullAssertion": "off",
-        "useShorthandArrayType": "error"
+        "noParameterAssign": "error",
+        "useAsConstAssertion": "error",
+        "useDefaultParameterLast": "error",
+        "useEnumInitializers": "error",
+        "useSelfClosingElements": "error",
+        "useSingleVarDeclarator": "error",
+        "noUnusedTemplateLiteral": "error",
+        "useNumberNamespace": "error",
+        "noInferrableTypes": "error",
+        "noUselessElse": "error",
+        "useConsistentArrayType": {
+          "level": "error",
+          "options": {
+            "syntax": "shorthand"
+          }
+        }
       },
       "suspicious": {
         "noArrayIndexKey": "off",
         "noConfusingVoidType": "off",
-        "noConsoleLog": "error",
         "noExplicitAny": "off",
         "noCommentText": "off",
         "noDuplicateAtImportRules": "off",
@@ -72,7 +89,13 @@
         "noImportantInKeyframe": "off",
         "noShorthandPropertyOverrides": "off",
         "noSuspiciousSemicolonInJsx": "off",
-        "useErrorMessage": "error"
+        "useErrorMessage": "error",
+        "noConsole": {
+          "level": "error",
+          "options": {
+            "allow": ["log"]
+          }
+        }
       },
       "security": {
         "noDangerouslySetInnerHtml": "off",

compact/src/Builder.ts

@@ -132,8 +132,10 @@ export class CompactBuilder {
       if (isPromisifiedChildProcessError(error)) {
         this.printOutput(error.stdout, chalk.cyan);
         this.printOutput(error.stderr, chalk.red);
+        // biome-ignore lint/suspicious/noConsole: Needed to display build failure reason
         console.error(chalk.red('[BUILD] ❌ Build failed:', error.message));
       } else if (error instanceof Error) {
+        // biome-ignore lint/suspicious/noConsole: Needed to display build failure reason
         console.error(chalk.red('[BUILD] ❌ Build failed:', error.message));
       }
 
@@ -153,7 +155,6 @@ export class CompactBuilder {
       .split('\n')
       .filter((line: string): boolean => line.trim() !== '')
       .map((line: string): string => `    ${line}`);
-    // biome-ignore lint/suspicious/noConsoleLog: needed for debugging
     console.log(colorFn(lines.join('\n')));
   }
 }

compact/src/Compiler.ts

@@ -127,6 +127,7 @@ export class CompactCompiler {
           }
           return [];
         } catch (err) {
+          // biome-ignore lint/suspicious/noConsole: Displays file path that failed to parse
           console.warn(`Error accessing ${fullPath}:`, err);
           return [];
         }
@@ -135,6 +136,7 @@ export class CompactCompiler {
       const results = await Promise.all(filePromises);
       return results.flat();
     } catch (err) {
+      // biome-ignore lint/suspicious/noConsole: Displays which directory failed to be read
       console.error(`Failed to read dir: ${dir}`, err);
       return [];
     }
@@ -193,7 +195,6 @@ export class CompactCompiler {
       .split('\n')
       .filter((line: string): boolean => line.trim() !== '')
       .map((line: string): string => `    ${line}`);
-    // biome-ignore lint/suspicious/noConsoleLog: needed for debugging
     console.log(colorFn(lines.join('\n')));
   }
 }

contracts/archive/src/test/simulators/ShieldedTokenSimulator.ts

@@ -3,20 +3,20 @@ import {
   type CircuitResults,
   type CoinPublicKey,
   type ContractState,
-  QueryContext,
   constructorContext,
   emptyZswapLocalState,
+  QueryContext,
 } from '@midnight-ntwrk/compact-runtime';
 import { sampleContractAddress } from '@midnight-ntwrk/zswap';
 import {
   type CoinInfo,
   type ContractAddress,
   type Either,
   type Ledger,
+  ledger,
   Contract as MockShielded,
   type SendResult,
   type ZswapCoinPublicKey,
-  ledger,
 } from '../../artifacts/MockShieldedToken/contract/index.cjs'; // Combined imports
 import {
   type ShieldedTokenPrivateState,

contracts/archive/src/test/utils/test.ts

@@ -3,8 +3,8 @@ import {
   type CoinPublicKey,
   type ContractAddress,
   type ContractState,
-  QueryContext,
   emptyZswapLocalState,
+  QueryContext,
 } from '@midnight-ntwrk/compact-runtime';
 import type { IContractSimulator } from '../types/test';
 

contracts/fungibleToken/src/test/simulators/FungibleTokenSimulator.ts

@@ -2,18 +2,18 @@ import {
   type CircuitContext,
   type CoinPublicKey,
   type ContractState,
-  QueryContext,
   constructorContext,
   emptyZswapLocalState,
+  QueryContext,
 } from '@midnight-ntwrk/compact-runtime';
 import { sampleContractAddress } from '@midnight-ntwrk/zswap';
 import {
   type ContractAddress,
   type Either,
   type Ledger,
+  ledger,
   Contract as MockFungibleToken,
   type ZswapCoinPublicKey,
-  ledger,
 } from '../../artifacts/MockFungibleToken/contract/index.cjs'; // Combined imports
 import {
   type FungibleTokenPrivateState,

contracts/fungibleToken/src/test/utils/test.ts

@@ -3,8 +3,8 @@ import {
   type CoinPublicKey,
   type ContractAddress,
   type ContractState,
-  QueryContext,
   emptyZswapLocalState,
+  QueryContext,
 } from '@midnight-ntwrk/compact-runtime';
 import type { IContractSimulator } from '../types/test.js';
 

contracts/multiToken/src/test/simulators/MultiTokenSimulator.ts

@@ -2,18 +2,18 @@ import {
   type CircuitContext,
   type CoinPublicKey,
   type ContractState,
-  QueryContext,
   constructorContext,
   emptyZswapLocalState,
+  QueryContext,
 } from '@midnight-ntwrk/compact-runtime';
 import { sampleContractAddress } from '@midnight-ntwrk/zswap';
 import {
   type ContractAddress,
   type Either,
   type Ledger,
+  ledger,
   Contract as MockMultiToken,
   type ZswapCoinPublicKey,
-  ledger,
 } from '../../artifacts/MockMultiToken/contract/index.cjs'; // Combined imports
 import {
   type MultiTokenPrivateState,

contracts/multiToken/src/test/utils/test.ts

@@ -3,8 +3,8 @@ import {
   type CoinPublicKey,
   type ContractAddress,
   type ContractState,
-  QueryContext,
   emptyZswapLocalState,
+  QueryContext,
 } from '@midnight-ntwrk/compact-runtime';
 import type { IContractSimulator } from '../types/test';
 

contracts/nonFungibleToken/src/test/nonFungibleToken.test.ts

@@ -2,11 +2,11 @@ import type { CoinPublicKey } from '@midnight-ntwrk/compact-runtime';
 import { beforeEach, describe, expect, it } from 'vitest';
 import { NonFungibleTokenSimulator } from './simulators/NonFungibleTokenSimulator.js';
 import {
-  ZERO_ADDRESS,
-  ZERO_KEY,
   createEitherTestContractAddress,
   createEitherTestUser,
   toHexPadded,
+  ZERO_ADDRESS,
+  ZERO_KEY,
 } from './utils/address.js';
 
 // Contract Metadata

contracts/nonFungibleToken/src/test/simulators/NonFungibleTokenSimulator.ts

@@ -2,18 +2,18 @@ import {
   type CircuitContext,
   type CoinPublicKey,
   type ContractState,
-  QueryContext,
   constructorContext,
   emptyZswapLocalState,
+  QueryContext,
 } from '@midnight-ntwrk/compact-runtime';
 import { sampleContractAddress } from '@midnight-ntwrk/zswap';
 import {
   type ContractAddress,
   type Either,
   type Ledger,
+  ledger,
   Contract as MockNonFungibleToken,
   type ZswapCoinPublicKey,
-  ledger,
 } from '../../artifacts/MockNonFungibleToken/contract/index.cjs'; // Combined imports
 import {
   type NonFungibleTokenPrivateState,

contracts/ownable/src/test/simulators/OwnableSimulator.ts

@@ -2,18 +2,18 @@ import {
   type CircuitContext,
   type CoinPublicKey,
   type ContractState,
-  QueryContext,
   constructorContext,
   emptyZswapLocalState,
+  QueryContext,
 } from '@midnight-ntwrk/compact-runtime';
 import { sampleContractAddress } from '@midnight-ntwrk/zswap';
 import {
   type ContractAddress,
   type Either,
   type Ledger,
+  ledger,
   Contract as MockOwnable,
   type ZswapCoinPublicKey,
-  ledger,
 } from '../../artifacts/MockOwnable/contract/index.cjs'; // Combined imports
 import {
   type OwnablePrivateState,

contracts/ownable/src/test/utils/test.ts

@@ -3,8 +3,8 @@ import {
   type CoinPublicKey,
   type ContractAddress,
   type ContractState,
-  QueryContext,
   emptyZswapLocalState,
+  QueryContext,
 } from '@midnight-ntwrk/compact-runtime';
 import type { IContractSimulator } from '../types/test.js';
 

contracts/utils/src/test/simulators/InitializableSimulator.ts

@@ -1,14 +1,14 @@
 import {
   type CircuitContext,
   type ContractState,
-  QueryContext,
   constructorContext,
+  QueryContext,
   sampleContractAddress,
 } from '@midnight-ntwrk/compact-runtime';
 import {
   type Ledger,
-  Contract as MockInitializable,
   ledger,
+  Contract as MockInitializable,
 } from '../../artifacts/MockInitializable/contract/index.cjs';
 import {
   type InitializablePrivateState,

contracts/utils/src/test/simulators/PausableSimulator.ts

@@ -1,14 +1,14 @@
 import {
   type CircuitContext,
   type ContractState,
-  QueryContext,
   constructorContext,
+  QueryContext,
   sampleContractAddress,
 } from '@midnight-ntwrk/compact-runtime';
 import {
   type Ledger,
-  Contract as MockPausable,
   ledger,
+  Contract as MockPausable,
 } from '../../artifacts/MockPausable/contract/index.cjs';
 import {
   type PausablePrivateState,

contracts/utils/src/test/simulators/UtilsSimulator.ts

@@ -1,17 +1,17 @@
 import {
   type CircuitContext,
   type ContractState,
-  QueryContext,
   constructorContext,
+  QueryContext,
 } from '@midnight-ntwrk/compact-runtime';
 import { sampleContractAddress } from '@midnight-ntwrk/zswap';
 import {
   type ContractAddress,
   type Either,
   type Ledger,
+  ledger,
   Contract as MockUtils,
   type ZswapCoinPublicKey,
-  ledger,
 } from '../../artifacts/MockUtils/contract/index.cjs'; // Combined imports
 import {
   type UtilsPrivateState,

contracts/utils/src/test/utils/test.ts

@@ -3,8 +3,8 @@ import {
   type CoinPublicKey,
   type ContractAddress,
   type ContractState,
-  QueryContext,
   emptyZswapLocalState,
+  QueryContext,
 } from '@midnight-ntwrk/compact-runtime';
 import type { IContractSimulator } from '../types/test.js';
 

package.json

@@ -24,7 +24,7 @@
     "@midnight-ntwrk/compact-runtime": "^0.8.1"
   },
   "devDependencies": {
-    "@biomejs/biome": "1.9.4",
+    "@biomejs/biome": "2.1.2",
     "@midnight-ntwrk/ledger": "^4.0.0",
     "@midnight-ntwrk/zswap": "^4.0.0",
     "@types/node": "^22",