Add extra memory manipulation functions #5792
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Hadrien Croubois <[email protected]>
Co-authored-by: Arr00 <[email protected]>
This reverts commit 3847050.
🦋 Changeset detectedLatest commit: 7158817 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Comment on lines
+89
to
+96
| /// @dev Returns a `Pointer` to the `value`'s header (i.e. includes the length word). | ||
| function asPointer(bytes memory value) internal pure returns (Pointer) { | ||
| bytes32 ptr; | ||
| assembly ("memory-safe") { | ||
| ptr := value | ||
| } | ||
| return asPointer(ptr); | ||
| } |
There was a problem hiding this comment.
Suggested change
| /// @dev Returns a `Pointer` to the `value`'s header (i.e. includes the length word). | |
| function asPointer(bytes memory value) internal pure returns (Pointer) { | |
| bytes32 ptr; | |
| assembly ("memory-safe") { | |
| ptr := value | |
| } | |
| return asPointer(ptr); | |
| } | |
| /// @dev Returns a `Pointer` to the `value`'s header (i.e. includes the length word). | |
| function asPointer(bytes memory value) internal pure returns (Pointer ptr) { | |
| assembly ("memory-safe") { | |
| ptr := value | |
| } | |
| } |
|
In #5680, I introduced an approach based on "memory slices", similar to calldata slice. That may be a (safer?) alternate to pure memory pointers |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #5189
PR Checklist
npx changeset add)