[PoC] impose EqualsAvoidsNull #2
Conversation
Pankraz76
force-pushed
the
org.openrewrite.rewrite
branch
from
2055dc7 to
b340b35
Compare
Pankraz76
force-pushed
the
org.openrewrite.rewrite
branch
from
d748359 to
c316ab2
Compare
Pankraz76
force-pushed
the
org.openrewrite.rewrite
branch
from
c316ab2 to
4df00c7
Compare
| static | ||
| public | ||
| // tag::user_guide[] | ||
| public class MyClassTemplateInvocationContextProvider |
There was a problem hiding this comment.
@marcphilipp might be missing config alignment of check, but this shoes once again that convention is the best config, might consider rewrite migration dropping the config burden promoting into 1LOC being a dedicated recipe, fully maintained by the community.
|
not saying rewrite it perfect, but we could enable the cache again when removing spot and check. Could you show me how to please? After removing all its only existent in some .md files not even clean works anymore. So im having trouble removing the other 2 plugins to show the real diff. With rewrite the whole config is imposed as convention fit into one screen. No need to say thats not quite the case yet, as even the line endings command from spot is mentioned 6-7 times. Rewrite is about having SSOT and relying on the convent over config principle. |
| val majorMinorVersion = "([0-9]+\\.[0-9]+).*".toRegex().matchEntire(fullVersion)!!.let { it.groups[1]!!.value } | ||
| eclipse(majorMinorVersion).configFile(javaFormatterConfigFile) | ||
| trimTrailingWhitespace() | ||
| endWithNewline() |
| * | ||
| * @param clazz the class to check; never {@code null} | ||
| * @return {@code true} if the class is {@code abstract} | ||
| * @see java.lang.reflect.Modifier#isAbstract(int) |
There was a problem hiding this comment.
check can do so well imho
| argThat(d -> d.getUniqueIdObject().equals(UniqueId.forEngine("engine-id")))); | ||
| inOrder.verify(executionListener).executionSkipped( | ||
| argThat(d -> d.getUniqueIdObject().getLastSegment().getType().equals("container")), | ||
| argThat(d -> "container".equals(d.getUniqueIdObject().getLastSegment().getType())), |
There was a problem hiding this comment.
check seems inconsistent as already approached in:
rewritecapability junit-team/junit-framework#4708I hereby agree to the terms of the JUnit Contributor License Agreement.
Definition of Done
@APIannotations