-
-
Notifications
You must be signed in to change notification settings - Fork 2k
add nx schemas #4866
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
add nx schemas #4866
Conversation
Thanks for the PR! This section of the codebase is owned by @madskristensen and |
Thanks - unfortunately |
it looks like the conflict is with this: schemastore/src/api/json/catalog.json Lines 4596 to 4611 in 44a0c7e
I'm not super familiar, but it appears to be a deprecated format according to Microsoft's docs (see here). If I add schemastore/src/schema-validation.jsonc Lines 287 to 294 in 44a0c7e
@hyperupcall thoughts on this solution? There's a comment that does explicitly say not to add additional exclusions, but I think it's unlikely that someone would be using Nx and this (maybe deprecated) Nuget format. |
{ | ||
"name": "Nx Project Schema", | ||
"description": "Configuration file for the Nx CLI and project defaults. Documentation: https://nx.dev/reference/project-configuration", | ||
"fileMatch": ["project.json"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you find a less generic name for the file match? Could you perhaps include the folder name that it always is located in, for instance?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately, I'm not sure of a way to do that. 😞
Nx is a language-agnostic tool for managing monorepos. Users can organize the packages within this monorepo however they want.
I understand that project.json
is a fairly generic name, I'm just working with what Nx has already established.
The only solution I can think of is the one I proposed here: #4866 (comment)
But do let me know if you have any other ideas!
If we aren't able to find an acceptable solution, we may just have to close this PR, but I'm hoping we can.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the feedback, the proposed solution works to fix the errors, but I don't think it fixes the underlying conflict. But I'm definitely open to revisiting this after some time maybe when most people have migrated off of project.json
(I'm not in the ASP.NET world)
This PR adds schemas for Nx's
project.json
andnx.json
.