Skip to content

add nx schemas #4866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

add nx schemas #4866

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions src/api/json/catalog.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8321,6 +8321,18 @@
"description": "Manifest YAML files for AWS Copilot services, environments, and pipelines. Documentation: https://aws.github.io/copilot-cli/docs/manifest/overview/",
"fileMatch": ["**/copilot/**/manifest.yml"],
"url": "https://sootyowl.github.io/aws-copilot-schemas/copilot-schema.json"
},
{
"name": "Nx Schema",
"description": "Configuration file for the Nx CLI and project defaults. Documentation: https://nx.dev/reference/nx-json",
"fileMatch": ["nx.json"],
"url": "https://raw.githubusercontent.com/nrwl/nx/master/packages/nx/schemas/nx-schema.json"
},
{
"name": "Nx Project Schema",
"description": "Configuration file for the Nx CLI and project defaults. Documentation: https://nx.dev/reference/project-configuration",
"fileMatch": ["project.json"],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you find a less generic name for the file match? Could you perhaps include the folder name that it always is located in, for instance?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately, I'm not sure of a way to do that. 😞
Nx is a language-agnostic tool for managing monorepos. Users can organize the packages within this monorepo however they want.

I understand that project.json is a fairly generic name, I'm just working with what Nx has already established.

The only solution I can think of is the one I proposed here: #4866 (comment)

But do let me know if you have any other ideas!
If we aren't able to find an acceptable solution, we may just have to close this PR, but I'm hoping we can.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the feedback, the proposed solution works to fix the errors, but I don't think it fixes the underlying conflict. But I'm definitely open to revisiting this after some time maybe when most people have migrated off of project.json (I'm not in the ASP.NET world)

"url": "https://raw.githubusercontent.com/nrwl/nx/master/packages/nx/schemas/project-schema.json"
}
]
}
Loading