Skip to content

Add hover information on associations #616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 17, 2025

Conversation

domingo2000
Copy link
Contributor

Closes #476

Add class information on hover in the associations for models.

We provide the same information that hover on constants provide, but in the symbol of the associations.

@domingo2000 domingo2000 requested a review from a team as a code owner June 1, 2025 16:09
@joshuay03
Copy link
Contributor

I only saw this after opening #630, so just a heads up that through association support would be good to add here if that gets merged first.

@vinistock vinistock added the enhancement New feature or request label Jul 16, 2025
Copy link
Member

@vinistock vinistock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good. For whatever reason, this PR's CI is also stuck. Can you please rebase?

@domingo2000 domingo2000 force-pushed the add-hover-on-associations branch from 3929b61 to bb69c81 Compare July 17, 2025 02:12
@domingo2000 domingo2000 force-pushed the add-hover-on-associations branch from bb69c81 to 5c5ad8e Compare July 17, 2025 02:17
@domingo2000
Copy link
Contributor Author

Just rebased and passed CI. But windows builds are still failing for some reason 😞 .

Copy link
Member

@vinistock vinistock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution!

@joshuay03 if you're interested in following up with the through support, please put up another PR.

@vinistock vinistock merged commit 2e64213 into Shopify:main Jul 17, 2025
12 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add hover for model associations
3 participants