-
Notifications
You must be signed in to change notification settings - Fork 50
Add toast api on standard api #3077
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
--- | ||
'@shopify/ui-extensions': patch | ||
--- | ||
|
||
Add toast api on customer accounts standard api |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -12,6 +12,7 @@ import { | |
Analytics, | ||
CustomerPrivacy, | ||
ApplyTrackingConsentChangeType, | ||
ToastApi, | ||
} from '../shared'; | ||
|
||
import type {ExtensionTarget} from '../../extension-targets'; | ||
|
@@ -101,6 +102,23 @@ export interface StandardApi<Target extends ExtensionTarget = ExtensionTarget> { | |
*/ | ||
ui: Ui; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Will remove toast type on here once we have completed moving this over + docs shipped but for now leaving it in here as we need the toast api on standard api to implement shopify.toast on the host |
||
|
||
/** | ||
* The Toast API displays a non-disruptive message that displays at the bottom | ||
* of the interface to provide quick, at-a-glance feedback on the outcome | ||
* of an action. | ||
* | ||
* How to use: | ||
* | ||
* - Use toasts to confirm successful actions. | ||
* | ||
* - Aim for two words. | ||
* | ||
* - Use noun + past tense verb format. For example, \`Changes saved\`. | ||
* | ||
* For errors, or information that needs to persist on the page, use a [banner](/docs/api/checkout-ui-extensions/unstable/components/feedback/banner) component. | ||
*/ | ||
toast: ToastApi; | ||
|
||
navigation: StandardExtensionNavigation; | ||
|
||
/** | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we currently do not support
hide
ui-extensions/packages/ui-extensions/src/surfaces/point-of-sale/render/api/toast-api/toast-api.ts
Line 11 in 93815b4
Are we going to implement this as part of the 2025-10 version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@robin-drexler Yes! we are adding support for it here https://github.com/shop/world/pull/106014
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Im updating this type so I can expose that change on standard api :)