-
Notifications
You must be signed in to change notification settings - Fork 50
Add toast api on standard api #3077
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
/** | ||
* Methods to interact with the extension's UI. | ||
*/ | ||
ui: Ui; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will remove toast type on here once we have completed moving this over + docs shipped but for now leaving it in here as we need the toast api on standard api to implement shopify.toast on the host
/snapit |
🫰✨ Thanks @oluwatimio! Your snapshot has been published to npm. Test the snapshot by updating your "@shopify/ui-extensions": "0.0.0-snapshot-20250714180216" |
} | ||
|
||
export interface ToastApiResult { | ||
hide: () => void; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we currently do not support hide
ui-extensions/packages/ui-extensions/src/surfaces/point-of-sale/render/api/toast-api/toast-api.ts
Line 11 in 93815b4
show: (content: string, options?: ShowToastOptions) => void; |
Are we going to implement this as part of the 2025-10 version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@robin-drexler Yes! we are adding support for it here https://github.com/shop/world/pull/106014
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Im updating this type so I can expose that change on standard api :)
2be16bc
to
f594ead
Compare
Background
Partially fixes https://github.com/shop/issues-checkout/issues/6460
Solution
Added a toast api on standard api itself
🎩
Im just adding the type and nothing else for now.
Will update docs and remove toast from ui in a follow up once implementation is complete in the host
Checklist