Skip to content

SLCORE-1631 Avoid running analysis on test failure #1543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 6, 2025
Merged

SLCORE-1631 Avoid running analysis on test failure #1543

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4b9e2a8
SLCORE-1631 Avoid running analysis on test failure
eray-felek-sonarsource Oct 24, 2025
7d59dfb
Rever the test case
eray-felek-sonarsource Nov 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 2 additions & 12 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,22 +72,12 @@ jobs:
SCANNER_VERSION: 5.1.0.4751
PULL_REQUEST: ${{ github.event.pull_request.number || '' }}
run: |
if git rev-parse --is-shallow-repository --quiet >/dev/null 2>&1; then
echo "Fetch Git references for SonarQube analysis..."
git fetch --unshallow || true
fi
maven_goals=("verify" "org.sonarsource.scanner.maven:sonar-maven-plugin:${SCANNER_VERSION}:sonar")
mvn verify
maven_goals=("org.sonarsource.scanner.maven:sonar-maven-plugin:${SCANNER_VERSION}:sonar")
maven_goals+=("-Pcoverage" "-Dcommercial")
sonar_props=("-Dsonar.host.url=${SONAR_HOST_URL}" "-Dsonar.token=${SONAR_TOKEN}")
sonar_props+=("-Dsonar.projectVersion=${CURRENT_VERSION}" "-Dsonar.scm.revision=$GITHUB_SHA")
sonar_props+=("-Dsonar.coverage.jacoco.xmlReportPaths=${{ github.workspace }}/report-aggregate/target/site/jacoco-aggregate/jacoco.xml")
if [[ "${GITHUB_EVENT_NAME:?}" == "pull_request" ]]; then
sonar_props+=("-Dsonar.pullrequest.key=$PULL_REQUEST")
sonar_props+=("-Dsonar.pullrequest.branch=$GITHUB_HEAD_REF")
sonar_props+=("-Dsonar.pullrequest.base=$GITHUB_BASE_REF")
echo "Fetch ${GITHUB_BASE_REF:?} for SonarQube analysis..."
git fetch origin "${GITHUB_BASE_REF}" || true
fi
echo "Maven command: mvn ${maven_goals[*]} ${sonar_props[*]}"
mvn "${maven_goals[@]}" "${sonar_props[@]}"
- name: Generate test report on failure
Expand Down
Loading