fix: add option to use old Windows 'start' command #1084
Merged
+30
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CyanVoxel
added
Type: Bug
3 tasks
github-project-automation
bot
moved this from 🏓 Ready for Review
to ✅ Done
in TagStudio Development
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1036 by adding a new
windows_start_commandoption in thesettings.tomlfile which toggles the pre-#667 file opener behavior on Windows. This is a niche option so I decided to not include it in the GUI and only make it available when editing the file itself.In order to test the full functionality of this PR, the option must be set to
true.I tested this on Windows 10 with "Photos" version 2025.11070.8001.0 by opening .jpg files with and without the option. Without it, I get the following message about 50% of the time with some times having the zoom locked and other times having no apparent issue at all.
Tasks Completed