Open
Conversation
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (19)
✅ Files skipped from review due to trivial changes (13)
🚧 Files skipped from review as they are similar to previous changes (5)
WalkthroughThis change enables the TypeScript compiler option 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
EvanHahn
force-pushed
the
claude/great-wing
branch
2 times, most recently
from
ebd21d5 to
f184dae
Compare
no ref **What?** This enables [TypeScript's `erasableSyntaxOnly` option][0] across the codebase. This means we can't use enums, namespaces, or a few other things. This change should have no user impact. **Why?** The big reason: [Node supports running TypeScript files directly][1], but only if all the syntax is erasable. This means we can remove build steps in many cases! It has a few other advantages, too: simplifying source maps, restricting some tricky parts of TypeScript, slightly accelerating TypeScript compilation, This doesn't enable some of the other options that are sometimes recommended in tandem, like `verbatimModuleSyntax`. Nor does it actually run `.ts` files with Node. Those are for another day. [0]: https://www.typescriptlang.org/tsconfig/#erasableSyntaxOnly [1]: https://nodejs.org/api/typescript.html#type-stripping
EvanHahn
force-pushed
the
claude/great-wing
branch
from
f184dae to
0747411
Compare
EvanHahn
added
the
ok to merge for me
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
no ref
What? This enables TypeScript's
erasableSyntaxOnlyoption across the codebase. This means we can't use enums, namespaces, or a few other things. This change should have no user impact.Why? The big reason: Node supports running TypeScript files directly, but only if all the syntax is erasable. This means we can remove build steps in many cases! It has a few other advantages, too: simplifying source maps, restricting some tricky parts of TypeScript, slightly accelerating TypeScript compilation,
This doesn't enable some of the other options that are sometimes recommended in tandem, like
verbatimModuleSyntax. Nor does it actually run.tsfiles with Node. Those are for another day.