Require erasable TypeScript syntax

apps/activitypub/src/api/activitypub.ts

@@ -167,11 +167,13 @@ export interface GetBlockedDomainsResponse {
     next: string | null;
 }
 
-export enum PostType {
-    Note = 0,
-    Article = 1,
-    Tombstone = 2
-}
+export const PostType = {
+    Note: 0,
+    Article: 1,
+    Tombstone: 2
+} as const;
+
+export type PostType = (typeof PostType)[keyof typeof PostType];
 
 export interface Post {
     id: string;
@@ -242,12 +244,22 @@ export const isApiError = (error: unknown): error is ApiError => {
 };
 
 export class ActivityPubAPI {
+    private readonly apiUrl: URL;
+    private readonly authApiUrl: URL;
+    private readonly handle: string;
+    private readonly fetch: (resource: URL, init?: RequestInit) => Promise<Response>;
+
     constructor(
-        private readonly apiUrl: URL,
-        private readonly authApiUrl: URL,
-        private readonly handle: string,
-        private readonly fetch: (resource: URL, init?: RequestInit) => Promise<Response> = window.fetch.bind(window)
-    ) {}
+        apiUrl: URL,
+        authApiUrl: URL,
+        handle: string,
+        fetch: (resource: URL, init?: RequestInit) => Promise<Response> = window.fetch.bind(window)
+    ) {
+        this.apiUrl = apiUrl;
+        this.authApiUrl = authApiUrl;
+        this.handle = handle;
+        this.fetch = fetch;
+    }
 
     private async getToken(): Promise<string | null> {
         try {

apps/activitypub/tsconfig.json

@@ -18,6 +18,7 @@
     "strict": true,
     "noUnusedLocals": true,
     "noUnusedParameters": true,
+    "erasableSyntaxOnly": true,
     "noFallthroughCasesInSwitch": true,
 
     /* Path aliases */

apps/admin-x-design-system/tsconfig.json

@@ -16,6 +16,7 @@
       "strict": true,
       "noUnusedLocals": true,
       "noUnusedParameters": true,
+      "erasableSyntaxOnly": true,
       "noFallthroughCasesInSwitch": true
     },
     "include": ["src"],

apps/admin-x-framework/src/utils/errors.ts

@@ -15,9 +15,12 @@ export interface ErrorResponse {
 }
 
 export class APIError extends Error {
+    public readonly response?: Response;
+    public readonly data?: unknown;
+
     constructor(
-        public readonly response?: Response,
-        public readonly data?: unknown,
+        response?: Response,
+        data?: unknown,
         message?: string,
         errorOptions?: ErrorOptions
     ) {
@@ -26,17 +29,22 @@ export class APIError extends Error {
         }
 
         super(message || 'Something went wrong, please try again.', errorOptions);
+        this.response = response;
+        this.data = data;
     }
 }
 
 export class JSONError extends APIError {
+    public readonly data?: ErrorResponse;
+
     constructor(
         response: Response,
-        public readonly data?: ErrorResponse,
+        data?: ErrorResponse,
         message?: string,
         errorOptions?: ErrorOptions
     ) {
         super(response, data, message, errorOptions);
+        this.data = data;
     }
 }
 

apps/admin-x-framework/tsconfig.json

@@ -16,6 +16,7 @@
       "strict": true,
       "noUnusedLocals": true,
       "noUnusedParameters": true,
+      "erasableSyntaxOnly": true,
       "noFallthroughCasesInSwitch": true
     },
     "include": ["src", "test"],

apps/comments-ui/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@tryghost/comments-ui",
-  "version": "1.4.0",
+  "version": "1.4.1",
   "license": "MIT",
   "repository": "https://github.com/TryGhost/Ghost",
   "author": "Ghost Foundation",

apps/comments-ui/tsconfig.json

@@ -19,6 +19,7 @@
     "strict": true,
     "noUnusedLocals": true,
     "noUnusedParameters": true,
+    "erasableSyntaxOnly": true,
     "noFallthroughCasesInSwitch": true,
 
     /* Vitest */

apps/portal/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@tryghost/portal",
-  "version": "2.67.0",
+  "version": "2.67.1",
   "license": "MIT",
   "repository": "https://github.com/TryGhost/Ghost",
   "author": "Ghost Foundation",

apps/portal/tsconfig.json

@@ -78,7 +78,7 @@
     // "isolatedModules": true,                          /* Ensure that each file can be safely transpiled without relying on other imports. */
     // "verbatimModuleSyntax": true,                     /* Do not transform or elide any imports or exports not marked as type-only, ensuring they are written in the output file's format based on the 'module' setting. */
     // "isolatedDeclarations": true,                     /* Require sufficient annotation on exports so other tools can trivially generate declaration files. */
-    // "erasableSyntaxOnly": true,                       /* Do not allow runtime constructs that are not part of ECMAScript. */
+    "erasableSyntaxOnly": true,                          /* Do not allow runtime constructs that are not part of ECMAScript. */
     // "allowSyntheticDefaultImports": true,             /* Allow 'import x from y' when a module doesn't have a default export. */
     "esModuleInterop": true,                             /* Emit additional JavaScript to ease support for importing CommonJS modules. This enables 'allowSyntheticDefaultImports' for type compatibility. */
     // "preserveSymlinks": true,                         /* Disable resolving symlinks to their realpath. This correlates to the same flag in node. */

apps/posts/tsconfig.json

@@ -18,6 +18,7 @@
         "strict": true,
         "noUnusedLocals": true,
         "noUnusedParameters": true,
+        "erasableSyntaxOnly": true,
         "noFallthroughCasesInSwitch": true,
 
         /* Path aliases */

apps/signup-form/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@tryghost/signup-form",
-  "version": "0.3.8",
+  "version": "0.3.9",
   "license": "MIT",
   "repository": "https://github.com/TryGhost/Ghost",
   "author": "Ghost Foundation",

apps/signup-form/tsconfig.json

@@ -19,6 +19,7 @@
     "strict": true,
     "noUnusedLocals": true,
     "noUnusedParameters": true,
+    "erasableSyntaxOnly": true,
     "noFallthroughCasesInSwitch": true
   },
   "include": ["src"],

apps/stats/tsconfig.json

@@ -18,6 +18,7 @@
     "strict": true,
     "noUnusedLocals": true,
     "noUnusedParameters": true,
+    "erasableSyntaxOnly": true,
     "noFallthroughCasesInSwitch": true,
 
     /* Path aliases */

e2e/data-factory/persistence/adapters/knex.ts

@@ -5,9 +5,11 @@
  * Knex-based persistence adapter for direct database access
  */
 export class KnexPersistenceAdapter implements PersistenceAdapter {
-    constructor(
-        private db: Knex
-    ) {}
+    private db: Knex;
+
+    constructor(db: Knex) {
+        this.db = db;
+    }
 
     async insert<T>(entityType: string, data: T): Promise<T> {
         // entityType is the table name for Knex

e2e/helpers/pages/admin/posts/post/post-preview-frames.ts

@@ -1,7 +1,9 @@
 import {FrameLocator, Locator, Page} from '@playwright/test';
 
 class PreviewFrame {
-    constructor(protected readonly page: Page) {
+    protected readonly page: Page;
+
+    constructor(page: Page) {
         this.page = page;
     }
 

e2e/tsconfig.json

@@ -82,6 +82,7 @@
     /* Interop Constraints */
     // "isolatedModules": true,                          /* Ensure that each file can be safely transpiled without relying on other imports. */
     // "verbatimModuleSyntax": true,                     /* Do not transform or elide any imports or exports not marked as type-only, ensuring they are written in the output file's format based on the 'module' setting. */
+    "erasableSyntaxOnly": true,                          /* Do not allow runtime constructs that are not part of ECMAScript. */
     // "allowSyntheticDefaultImports": true,             /* Allow 'import x from y' when a module doesn't have a default export. */
     "esModuleInterop": true,                             /* Emit additional JavaScript to ease support for importing CommonJS modules. This enables 'allowSyntheticDefaultImports' for type compatibility. */
     // "preserveSymlinks": true,                         /* Disable resolving symlinks to their realpath. This correlates to the same flag in node. */

ghost/core/core/server/services/activitypub/activity-pub-service.ts

@@ -17,12 +17,22 @@
 }
 
 export class ActivityPubService {
+    private knex: Knex;
+    private siteUrl: URL;
+    private logging: Logger;
+    private identityTokenService: IdentityTokenService;
+
     constructor(
-        private knex: Knex,
-        private siteUrl: URL,
-        private logging: Logger,
-        private identityTokenService: IdentityTokenService
-    ) {}
+        knex: Knex,
+        siteUrl: URL,
+        logging: Logger,
+        identityTokenService: IdentityTokenService
+    ) {
+        this.knex = knex;
+        this.siteUrl = siteUrl;
+        this.logging = logging;
+        this.identityTokenService = identityTokenService;
+    }
 
     getExpectedWebhooks(secret: string): ExpectedWebhook[] {
         return [

ghost/core/core/server/services/identity-tokens/identity-token-service.ts

@@ -1,11 +1,19 @@
 import {sign} from 'jsonwebtoken';
 
 export class IdentityTokenService {
+    private privateKey: string;
+    private issuer: string;
+    private keyId: string;
+
     constructor(
-        private privateKey: string,
-        private issuer: string,
-        private keyId: string
-    ) {}
+        privateKey: string,
+        issuer: string,
+        keyId: string
+    ) {
+        this.privateKey = privateKey;
+        this.issuer = issuer;
+        this.keyId = keyId;
+    }
 
     async getTokenForUser(email: string, role?: string) {
         const claims: Record<string, string> = {

ghost/core/tsconfig.json

@@ -70,6 +70,7 @@
         /* Interop Constraints */
         // "isolatedModules": true,                          /* Ensure that each file can be safely transpiled without relying on other imports. */
         // "verbatimModuleSyntax": true,                     /* Do not transform or elide any imports or exports not marked as type-only, ensuring they are written in the output file's format based on the 'module' setting. */
+        "erasableSyntaxOnly": true,                          /* Do not allow runtime constructs that are not part of ECMAScript. */
         // "allowSyntheticDefaultImports": true,             /* Allow 'import x from y' when a module doesn't have a default export. */
         "esModuleInterop": true, /* Emit additional JavaScript to ease support for importing CommonJS modules. This enables 'allowSyntheticDefaultImports' for type compatibility. */
         // "preserveSymlinks": true,                         /* Disable resolving symlinks to their realpath. This correlates to the same flag in node. */