feat: Add ButtonSubmit #807
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a note about existing similar functionality that requires tweaks.
Removed BlockMediaViewer and updated BlockRichText entry. Adjusted completion status for DetailMedia.
pghorpade
temporarily deployed
to
netlify-preview
GitHub Actions
Inactive
github-actions
bot
temporarily deployed
to
storybook--pull_request_target-807
pghorpade
requested changes
Oct 1, 2025
NOTES.md
Outdated
| @@ -0,0 +1,11 @@ | |||
| Designs: | |||
There was a problem hiding this comment.
Remove notes.md file. I copied this in the PR description
There was a problem hiding this comment.
Also we should be adding dlc theme to this component https://ucla-library-storybook.netlify.app/?path=/story/nav-search--default-with-placeholder-prop
There was a problem hiding this comment.
We dont need this new component
There was a problem hiding this comment.
This component is used in SearchFieldComposite.
SearchFieldComposite is representing this component from Figma designs
Example 1:
Example 2:
There was a problem hiding this comment.
@lux-v I understand it is used in searchfiledcomposite. But we can use navSearch to create this
pghorpade
temporarily deployed
to
netlify-preview
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Component Created: ButtonSubmit.vue
Stories: ~/stories/ButtonSubmit.stories.js
Spec: ~/stories/ButtonSubmit.spec.js
Notes:
Designs:
https://www.figma.com/design/CDhWDARLb36ftkQce1LyLC/Breakpoints?node-id=1-25&m=dev
https://www.figma.com/design/CDhWDARLb36ftkQce1LyLC/Breakpoints?node-id=1-26&p=f&m=dev
Read in Recording:
https://drive.google.com/file/d/17tiGmE4aax-faoo5Rjue2Idbx3OGCFGa/view?usp=sharing
Relevant Links
https://www.library.ucla.edu/
https://digital.library.ucla.edu/catalog/ark:/21198/z1x98m6j
Checklist:
library-website-nuxt dev server