Skip to content
Closed
Show file tree
Hide file tree
Changes from 128 commits
Commits
Show all changes
132 commits
Select commit Hold shift + click to select a range
db8da7f
adds components list
dChiamp Jun 20, 2025
bd57d86
Update COMPONENTS.md
Sveb Jun 20, 2025
4fa76ad
Update COMPONENTS.md
Sveb Jun 20, 2025
b4dc86d
Update COMPONENTS.md
Sveb Jun 23, 2025
285e079
Update COMPONENTS.md
Sveb Jun 23, 2025
213a640
adds notes
dChiamp Jun 23, 2025
3004c74
Update COMPONENTS.md
Sveb Jun 24, 2025
7a1e0aa
Merge branch 'main' of https://github.com/funkhaus/ucla-library-websi…
dChiamp Jun 24, 2025
e955637
claimed component
austinblanchard Jun 24, 2025
d5e45d1
Update COMPONENTS.md
Sveb Jun 25, 2025
d49eaf5
claim a component
lux-v Jun 25, 2025
4b6cccf
claim a component
lux-v Jun 25, 2025
bfa79d4
Update COMPONENTS.md
Sveb Jun 25, 2025
4852133
Update COMPONENTS.md
Sveb Jun 25, 2025
2120974
Update COMPONENTS.md
Sveb Jun 25, 2025
c5d0581
take a component
lux-v Jun 25, 2025
fa2c258
add button-submit
lux-v Jun 25, 2025
d8241a2
remove unused import
lux-v Jun 25, 2025
af0a6b3
take a component
lux-v Jun 25, 2025
2e73be7
take a component
lux-v Jun 25, 2025
88bfe5e
Update COMPONENTS.md
austinblanchard Jun 25, 2025
54deec4
Change storybook group name
lux-v Jun 26, 2025
5d50d29
Change storybook group name
lux-v Jun 26, 2025
fa5a44b
add background color to button
lux-v Jun 26, 2025
581dafd
add breakpoints
lux-v Jun 26, 2025
22b88d7
Update COMPONENTS.md
Sveb Jun 26, 2025
302c066
format a component with prettier
lux-v Jun 26, 2025
498ab73
Adjust the component name - already exists
Sveb Jun 30, 2025
3fd88d6
change hover color
lux-v Jun 30, 2025
09c2fd0
take a component
lux-v Jul 1, 2025
0c75f77
take a component
lux-v Jul 1, 2025
a7bf5fa
Update COMPONENTS.md
Sveb Jul 1, 2025
069c123
Update COMPONENTS.md
Sveb Jul 7, 2025
cdb4a86
Update COMPONENTS.md
Sveb Jul 7, 2025
8a29837
Update COMPONENTS.md
austinblanchard Jul 7, 2025
7bdfa7a
Update COMPONENTS.md - marking BentoPod
Sveb Jul 8, 2025
bc0154d
add component
lux-v Jul 8, 2025
597ef57
add component
lux-v Jul 8, 2025
02aafc7
Update COMPONENTS.md
austinblanchard Jul 8, 2025
e675c1b
Update COMPONENTS.md
austinblanchard Jul 8, 2025
2933c6d
take a component
lux-v Jul 9, 2025
d5c665a
take a component
lux-v Jul 9, 2025
e539e14
fix component description
lux-v Jul 9, 2025
4808e2d
Update COMPONENTS.md
Sveb Jul 10, 2025
e372e04
Update COMPONENTS.md
Sveb Jul 10, 2025
7d5d656
change component's name
lux-v Jul 11, 2025
ed656cf
Update COMPONENTS.md
Sveb Jul 14, 2025
877fb65
take a component
lux-v Jul 14, 2025
348494b
take a component
lux-v Jul 15, 2025
45e6cf7
take a component
lux-v Jul 16, 2025
183375c
remove AssetFeaturedImage definition
lux-v Jul 16, 2025
ee9dd92
take a component
lux-v Jul 16, 2025
62919e6
take a components
lux-v Jul 16, 2025
51430d6
take a components
lux-v Jul 16, 2025
f6de890
take a component
lux-v Jul 16, 2025
76226de
take a component
lux-v Jul 16, 2025
d78dda6
add a new line
lux-v Jul 16, 2025
7388620
add detailed component description
lux-v Jul 16, 2025
63b619b
add detailed component description
lux-v Jul 16, 2025
e277dbe
take a component
lux-v Jul 16, 2025
08e03ec
update component description
lux-v Jul 16, 2025
0ee907a
Adds a button component
Sveb Jul 17, 2025
864171d
Update COMPONENTS.md
Sveb Jul 17, 2025
1bb618a
Update COMPONENTS.md
Sveb Jul 17, 2025
54df91d
Update COMPONENTS.md
Sveb Jul 17, 2025
0ed4fbb
Clean up components.md
Sveb Jul 17, 2025
b06efac
Taking the block-collection component
Sveb Jul 21, 2025
d31c91f
Taking the grid-collections component as well.
Sveb Jul 21, 2025
94304d5
Update COMPONENTS.md
Sveb Jul 21, 2025
279744a
Clean up component list
Sveb Jul 23, 2025
82e0566
add spacing
lux-v Jul 23, 2025
d24c553
add spacing
lux-v Jul 23, 2025
1a7297f
add dlc theme
lux-v Jul 23, 2025
c69bfac
Merge branch 'UCLALibrary:main' into main
lux-v Aug 5, 2025
0f9c0aa
update component name
lux-v Aug 6, 2025
a10aa20
Update Button definition
lux-v Aug 11, 2025
7f9084e
Update COMPONENTS.md
lux-v Aug 11, 2025
4b9de5d
Update COMPONENTS.md
lux-v Aug 11, 2025
f3b329f
Remove duplicates
lux-v Aug 11, 2025
2f4300d
remove duplicates
lux-v Aug 11, 2025
2cde0d3
remove duplicates
lux-v Aug 11, 2025
df42ca4
Remove already existing components
lux-v Aug 11, 2025
3db154c
Merge branch 'main' into main
lux-v Aug 12, 2025
9287f6d
take a component
lux-v Aug 12, 2025
fe7041b
add a component
lux-v Aug 15, 2025
05911af
Take a component
Sveb Aug 15, 2025
92f95f4
adjust prop for block anchor nav
lux-v Aug 15, 2025
b876c86
take a component
lux-v Aug 15, 2025
1d0497d
Update COMPONENTS.md
lux-v Aug 18, 2025
eec9a91
Merge branch 'main' into main
lux-v Aug 18, 2025
4a3040f
Taking the DropdownSingleSelect
Sveb Aug 19, 2025
f72144c
Take the ButtonDropdownSearch component
Sveb Aug 20, 2025
9beaa8f
Merge branch 'UCLALibrary:main' into main
lux-v Aug 26, 2025
95d50e6
adding the correct packageMenager version for netlify to see.
Sveb Aug 27, 2025
3aeb5a6
Merge pull request #30 from Sveb/installing-the-correct-pnpnm
Sveb Aug 27, 2025
5af7c53
Merge branch 'main' of https://github.com/lux-v/ucla-library-website-…
lux-v Aug 28, 2025
385d18f
Merge branch 'main' of https://github.com/funkhaus/ucla-library-websi…
lux-v Aug 28, 2025
2954cb3
lint fix
lux-v Aug 28, 2025
73a286e
Merge branch 'UCLALibrary:main' into main
lux-v Sep 2, 2025
0b53484
Merge branch 'main' of https://github.com/lux-v/ucla-library-website-…
lux-v Sep 2, 2025
74807a1
remove packageManager
lux-v Sep 2, 2025
7947268
add proper storybook name
lux-v Sep 2, 2025
4e2c716
add new line
lux-v Sep 2, 2025
f3e47de
Update COMPONENTS.md
Sveb Sep 3, 2025
cab92c8
Merge branch 'UCLALibrary:main' into main
lux-v Sep 3, 2025
4284ea6
Marking a component as taken
Sveb Sep 3, 2025
170b39f
Remove packageManager field from package.json
Sveb Sep 4, 2025
336fda4
Update component statuses and remove completed items
Sveb Sep 4, 2025
fb8fc47
Merge branch 'UCLALibrary:main' into main
lux-v Sep 4, 2025
21bfbcd
Update COMPONENTS.md
Sveb Sep 8, 2025
b8a8d23
Taking the FiltersDropdown
Sveb Sep 8, 2025
345f8b9
Update COMPONENTS.md
lux-v Sep 8, 2025
89788c4
Add note regarding existing header component tweaks
lux-v Sep 8, 2025
cfbbcd4
Update RefineSearchPanel ownership in COMPONENTS.md
Sveb Sep 10, 2025
90661b7
Update DetailMedia component owner to Svebor
Sveb Sep 11, 2025
12725ef
Update component list
austinblanchard Sep 11, 2025
202ef87
Merge branch 'UCLALibrary:main' into main
lux-v Sep 11, 2025
690b044
Clarify CTAHexButton entry in COMPONENTS.md
lux-v Sep 11, 2025
3fe1723
Update COMPONENTS.md to remove and modify components
Sveb Sep 12, 2025
6bc549e
Update component status and ownership in COMPONENTS.md
Sveb Sep 15, 2025
f570d75
Update component ownership in COMPONENTS.md
Sveb Sep 15, 2025
5a8fab1
Merge branch 'UCLALibrary:main' into main
lux-v Sep 16, 2025
d902719
Merge branch 'UCLALibrary:main' into main
lux-v Sep 18, 2025
fb48e3b
Merge branch 'UCLALibrary:main' into main
lux-v Sep 22, 2025
e8a0500
Merge branch 'UCLALibrary:main' into main
lux-v Sep 29, 2025
50aeb69
Merge branch 'UCLALibrary:main' into main
lux-v Oct 1, 2025
d388628
Merge branch 'main' of https://github.com/funkhaus/ucla-library-websi…
lux-v Oct 1, 2025
edfe481
Merge branch 'main' into button-submit
pghorpade Oct 1, 2025
c8f5fbb
Merge branch 'UCLALibrary:main' into main
lux-v Oct 2, 2025
d759bc3
Merge branch 'main' of https://github.com/funkhaus/ucla-library-websi…
lux-v Oct 2, 2025
3d73304
remove NOTES.md
lux-v Oct 2, 2025
124297f
Merge branch 'main' into button-submit
pghorpade Oct 2, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions NOTES.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
Designs:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove notes.md file. I copied this in the PR description

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We dont need this new component

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This component is used in SearchFieldComposite.

SearchFieldComposite is representing this component from Figma designs
Example 1:
image

Example 2:
image

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lux-v I understand it is used in searchfiledcomposite. But we can use navSearch to create this
image

Copy link
Contributor

@pghorpade pghorpade Oct 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lux-v close this PR and update SearchComposite to use NavSearch

https://www.figma.com/design/CDhWDARLb36ftkQce1LyLC/Breakpoints?node-id=1-25&m=dev

https://www.figma.com/design/CDhWDARLb36ftkQce1LyLC/Breakpoints?node-id=1-26&p=f&m=dev

Read in Recording:
https://drive.google.com/file/d/17tiGmE4aax-faoo5Rjue2Idbx3OGCFGa/view?usp=sharing

Relevant Links
https://www.library.ucla.edu/
https://digital.library.ucla.edu/catalog/ark:/21198/z1x98m6j
31 changes: 31 additions & 0 deletions packages/vue-component-library/src/lib-components/ButtonSubmit.vue
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
<script setup>
// Imports
import { computed, useSlots } from 'vue'
import IconSearch from 'ucla-library-design-tokens/assets/svgs/icon-search.svg'
import { useTheme } from '@/composables/useTheme'

const emit = defineEmits(['click'])
const slots = useSlots()

const theme = useTheme()

// Computeds
const classes = computed(() => ['button-submit', theme?.value || ''])

// Methods
function handleClick() {
emit('click')
}
</script>

<template>
<button :class="classes" type="submit" @click="handleClick">
<slot>
<IconSearch />
</slot>
</button>
</template>

<style lang="scss" scoped>
@import "@/styles/dlc/_button-submit.scss";
</style>
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
describe('Funkhaus / Button Submit', () => {
it('Default', () => {
cy.visit('/iframe.html?id=funkhaus-button-submit--default&args=&viewMode=story')
cy.get('.button-submit').should('exist')

cy.percySnapshot('Funkhaus / Button Submit')
})
})
61 changes: 61 additions & 0 deletions packages/vue-component-library/src/stories/ButtonSubmit.stories.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,61 @@
import SvgIconEye from 'ucla-library-design-tokens/assets/svgs/icon-eye.svg'
import { computed } from 'vue'
import ButtonSubmit from '@/lib-components/ButtonSubmit'

export default {
title: 'Funkhaus / Button Submit',
component: ButtonSubmit,
}

const methods = {
onSubmit() {
alert('Button clicked!')
},
}

// Variations of stories below
export function Default() {
return {
components: { ButtonSubmit },
provide() {
return {
theme: computed(() => 'dlc'),
}
},
methods,
template: '<button-submit @click="onSubmit" />',
}
}

export function WithCustomIcon() {
return {
components: { ButtonSubmit },
provide() {
return {
theme: computed(() => 'dlc'),
}
},
data() {
return {
customIcon: SvgIconEye,
}
},
methods,
template: `
<button-submit @click="onSubmit">
<template #default>
<component :is="customIcon" />
</template>
</button-submit>
`,
}
}

// Variant: No theme provided (falls back to base styles)
export function NoThemeProvided() {
return {
components: { ButtonSubmit },
methods,
template: '<button-submit @click="onSubmit" />',
}
}
38 changes: 38 additions & 0 deletions packages/vue-component-library/src/styles/dlc/_button-submit.scss
Original file line number Diff line number Diff line change
@@ -0,0 +1,38 @@
.button-submit,
.dlc.button-submit {
display: flex;
align-items: center;
justify-content: center;

height: 74px;
width: 74px;
padding: 0;
background-color: var(--color-primary-blue-01);

// Target SVG elements
:deep(svg path) {
fill: var(--color-primary-blue-04);
transition: fill 0.3s ease-in-out;
}

// Hovers
@media #{$has-hover} {
&:hover {
:deep(svg path) {
fill: var(--color-default-cyan-03);
}
}
}
// Breakpoints
@media #{$medium} {
height: 53px;
}
@media #{$small} {
height: 60px;

// Target SVG elements
:deep(svg path) {
fill: var(--color-default-cyan-03);
}
}
}