fix: OnValueChanged not being triggered on collections when the collection changes back to the previous value #3539
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NoelStephensUnity
approved these changes
Jul 10, 2025
…/com.unity.netcode.gameobjects into fix/collection-authority-onvaluechanged
| // lowest risk approach to resolving the issue where a client with no write permissions could make changes to a collection locally | ||
| // which can cause a myriad of issues. | ||
| private protected T m_InternalOriginalValue; | ||
| /// <summary> |
EmandM
added
port:1.x-completed
EmandM
added a commit
that referenced
this pull request
Jul 28, 2025
https://jira.unity3d.com/browse/MTTB-1421 fixes: #3534 ## Changelog - Fixed: When calling `CheckDirtyState(true)` on a `NetworkVariable` collection, `OnValueChanged` now triggers on the authority if the authority has changed the collection and then changed it back to the initial state in the same frame. This matches the behaviour of non-collection NetworkVariables. ## Testing and Documentation - Includes unit tests. - Includes integration tests. ## Backport This is a backport of #3539
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.unity3d.com/browse/MTTB-1421
fixes: #3534
Changelog
CheckDirtyState(true)on aNetworkVariablecollection,OnValueChangednow triggers on the authority if the authority has changed the collection and then changed it back to the initial state in the same frame. This matches the behaviour of non-collection NetworkVariables.Testing and Documentation
Backport
Backported by #3544