fix: Replaced HashSet.UnionWith() with loop in NetworkBehaviourUpdate() to avoid heap alloc #3568
+5
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nity.netcode.gameobjects into fix/nbu-heap-alloc
|
Quick note that you need to manually add this entry to the CHANGELOG in HERE. Also this is targeting |
EmandM
added
port:2.x-completed
NoelStephensUnity
added a commit
that referenced
this pull request
Aug 5, 2025
…loc (#3573) Discovered while profiling a server that had frequent pending dirty network objects to process ## Changelog Fixed: Removed heap alloc in NetworkBehaviourUpdate ## Testing and Documentation - No tests have been added. - No documentation changes or additions were necessary. ## Backport This is an up-port of #3568 --------- Co-authored-by: Louis McLaughlin <[email protected]> Co-authored-by: Noel Stephens <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discovered while profiling a server that had frequent pending dirty network objects to process
Changelog
Fixed: Removed heap alloc in NetworkBehaviourUpdate
Testing and Documentation
Backport
Up-ported by #3573