added fields to OnlineClient #30
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevenh
suggested changes
Sep 10, 2020
| } | ||
|
|
||
| // ClientList returns a list of online clients. | ||
| func (s *ServerMethods) ClientList() ([]*OnlineClient, error) { | ||
| var clients []*OnlineClient | ||
| if _, err := s.ExecCmd(NewCmd("clientlist").WithResponse(&clients)); err != nil { | ||
| if _, err := s.ExecCmd(NewCmd("clientlist -away -voice -country").WithResponse(&clients)); err != nil { |
There was a problem hiding this comment.
Are these the only options or should they be configurable?
Also as they are optional is there a performance reason not to specify them all the time?
| @@ -358,12 +358,15 @@ type OnlineClient struct { | |||
| Type int `ms:"client_type"` | |||
| Away bool `ms:"client_away"` | |||
| AwayMessage string `ms:"client_away_message"` | |||
| Country string `ms:"client_country"` | |||
| InputMuted bool `ms:"client_input_muted"` | |||
| OutputMuted bool `ms:"client_output_muted"` | |||
There was a problem hiding this comment.
We should also add validation of the data to the tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.