Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On #166 the PNG were optimized to save file space:
But we don't need to embed opaque images as PNG, using JPEG would save more file space!
So images like
unvanquished,tyrantandlogoare still kept as PNG since have have transparency, butbackground,headerandsplashare now JPEG.The PNG files of them are kept because they are the source, but they aren't embedded.
The size of those PNGs was 480K, converted to JPEG the size is 72K, so this saves 408K.
I compressed this way:
So I used a quality of 90. If it's considered to low, the quality 95 would produce 96K for the three of them. We may also mix, the splash needs to have good enough quality, the others less.