Skip to content

Embed opaque images as JPEG #170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 25, 2025
+13 −6
Merged

Embed opaque images as JPEG #170

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions main.qml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ ApplicationWindow {
Image {
width: parent.width
height: parent.height
source: "qrc:/resources/background.png"
source: "qrc:/resources/background.jpg"
}

Rectangle {
Expand All @@ -70,7 +70,7 @@ ApplicationWindow {
top: parent.top
topMargin: parent.height * 0.1
}
source: "qrc:/resources/header.png"
source: "qrc:/resources/header.jpg"
}
Rectangle {
anchors.top: header.bottom
Expand Down
6 changes: 3 additions & 3 deletions qml.qrc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,13 +8,13 @@
<file>NewsCard.qml</file>
<file>DownloadInfo.qml</file>
<file>UpdateFailed.qml</file>
<file>resources/splash.png</file>
<file>resources/splash.jpg</file>
<file>splash.qml</file>
<file>Settings.qml</file>
<file>utils.js</file>
<file>resources/unvanquished.png</file>
<file>resources/background.png</file>
<file>resources/header.png</file>
<file>resources/background.jpg</file>
<file>resources/header.jpg</file>
<file>resources/logo.png</file>
<file>resources/tyrant.png</file>
<file>resources/net.unvanquished.Unvanquished.desktop</file>
Expand Down
Binary file added resources/background.jpg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
7 changes: 7 additions & 0 deletions resources/convert-jpg.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
#! /usr/bin/env bash

guetzli --nomemlimit --quality 84 header.png header.jpg &
guetzli --nomemlimit --quality 84 background.png background.jpg &
guetzli --nomemlimit --quality 93 splash.png splash.jpg &

wait
Binary file added resources/header.jpg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added resources/splash.jpg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 1 addition & 1 deletion splash.qml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ ApplicationWindow {
Image {
width: parent.width
height: parent.height
source: "qrc:/resources/splash.png"
source: "qrc:/resources/splash.jpg"
}

FluidControls.BodyLabel {
Expand Down