-
Couldn't load subscription status.
- Fork 261
Rust API: Add Data Renderer API #7438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The previous approach of reference counting did lead to crashes as the renderer was freed after registration :/
|
For tests it would be similar to the render layer one, however seeing as you may be writing them blind (not sure if you have a headless supporting license) whenever this PR is ready for review I can write the tests for the API. For rust we typically have the |
That would be awesome because my personal license does not support headless operation, and I'm not too familiar with writing tests for Binary Ninja.
Yes, that sounds good! |
|
Thank you for helping push this through, I made some changes to the API that I think better reflect how its intended to be used and some other comments that I think help clarify things that are not as obvious. Please let me know if this looks acceptable and i will squash all the changes up and merge (with you and @rbran as author) |
|
Thanks for improving the API even further. The final result looks good to me, and it also works for my custom data renderer plugin. |
|
Added with 64633f6 thank you! |
This pull request adds an implementation for the data renderer API currently available for Python and C++ plugins. My work is based on #6721. This PR fixes #6485. I've added an example plugin which renders UUIDs of the Mach-O load command
LD_UUID.The tests for this feature are currently in progress. What kind of tests would you expect for this feature, should they be similar to
render_layer.rs?