AAP-47753: Implement run_pattern_task() for PatternViewSet #15

alinabuzachis · 2025-07-02T10:51:23Z

https://issues.redhat.com/browse/AAP-47753

sonarqubecloud · 2025-07-24T23:57:57Z

Quality Gate failed

hakbailey

The documentation needs to be updated to include the new required and optional env variables used to connect to an AAP/aap-dev instance.

pattern_service/settings/defaults.py

pattern_service/settings/aap.py

core/controller_client.py

core/services.py

core/views.py

core/tasks.py

Signed-off-by: Alina Buzachis <[email protected]>

abikouo · 2025-08-06T11:14:07Z

pattern_service/settings/aap.py

+)
+
+
+def _validate_url(url: str) -> str:


Why do we have this file here? It seems that it is used to validate the settings.AAP_URL, which can be part of a utils directory and called in the ready() function of the App config

@abikouo Can you please let me know if the changes meet your expectations? Thanks.

abikouo · 2025-08-06T11:15:23Z

core/utils.py

+from typing import Iterator
+from urllib.parse import urljoin
+
+from pattern_service.settings.aap import AAP_URL


You should import the django.conf.settings instead

abikouo · 2025-08-06T11:24:05Z

core/controller_client.py

+from requests import Session
+from requests.auth import HTTPBasicAuth
+
+from pattern_service.settings.aap import AAP_PASSWORD


The settings are directly available as django.conf import settings

Signed-off-by: Alina Buzachis <[email protected]>

abikouo

Looks good overall, but still not getting the point why we need the settings/aap.py file

alinabuzachis · 2025-08-06T14:14:10Z

Looks good overall, but still not getting the point why we need the settings/aap.py file

The idea behind this file was to manage the authentication credentials for AAP needed to download the collection from the hub instance. I'm open to suggestions, so feel free to propose something else.

abikouo · 2025-08-06T15:46:48Z

Looks good overall, but still not getting the point why we need the settings/aap.py file

The idea behind this file was to manage the authentication credentials for AAP needed to download the collection from the hub instance. I'm open to suggestions, so feel free to propose something else.

I understand the point, but currently, the file aap.py has no effect since it is not imported anywhere.
The fact that you are calling settings.AAP_URL, means the app expects the AAP_URL to be defined somewhere in the settings. You can just ensure that the required AAP variables are defined in the apps ready() function.
In the settings file, we are already doing a dynamic configuration, which means when deploying the app, you just need to define the env variable PATTERN_SERVICE_AAP_URL (same for others required variables) and this will be turned to AAP_URL into the settings.

Signed-off-by: Alina Buzachis <[email protected]>

alinabuzachis · 2025-08-06T16:03:51Z

I understand the point, but currently, the file aap.py has no effect since it is not imported anywhere. The fact that you are calling settings.AAP_URL, means the app expects the AAP_URL to be defined somewhere in the settings. You can just ensure that the required AAP variables are defined in the apps ready() function. In the settings file, we are already doing a dynamic configuration, which means when deploying the app, you just need to define the env variable PATTERN_SERVICE_AAP_URL (same for others required variables) and this will be turned to AAP_URL into the settings.

Ok, right! I remove the app.py file and added the required check inside the ready(). Let me know please if anything else needs to be updated.

beeankha · 2025-08-06T23:09:21Z

core/task_runner.py

+
+    Args:
+        pattern_id (int): The ID of the pattern to process.
+        task_id (int): The ID of the task..


Suggested change

task_id (int): The ID of the task..

task_id (int): The ID of the task.

beeankha

Just one super minor edit

Signed-off-by: Alina Buzachis <[email protected]>

GomathiselviS

Just a couple of minor comments, otherwise this LGTM.

GomathiselviS · 2025-08-07T17:31:08Z

core/task_runner.py

+        logger.error(f"Could not find pattern definition for task {task_id}")
+        task.mark_failed({"error": "Pattern definition not found."})
+    except Exception as e:
+        logger.error(f"Task {task_id} failed: {e}")


Can we use logger.exception to include the full traceback in logs for debugging?

except Exception: error_message = "An unexpected error occurred." logger.exception(f"Task {task_id} failed unexpectedly.") task.mark_failed({"error": error_message})

GomathiselviS · 2025-08-07T17:51:22Z

core/utils/controller/helpers.py

+    temporary directory.
+
+    Args:
+        collection: The name of the collection (e.g., 'my_namespace.my_collection').


Suggested change

collection: The name of the collection (e.g., 'my_namespace.my_collection').

collection_name: The name of the collection (e.g., 'my_namespace.my_collection').

Signed-off-by: Alina Buzachis <[email protected]>

core/models.py

core/tests/test_controller_client.py

pyproject.toml

core/utils/controller/helpers.py

Signed-off-by: Alina Buzachis <[email protected]>

hakbailey

Just a few more small changes.

core/utils/controller/helpers.py

Signed-off-by: Alina Buzachis <[email protected]>

alinabuzachis marked this pull request as draft July 2, 2025 10:51

alinabuzachis force-pushed the async_create_pattern branch 4 times, most recently from c67dc6e to 35c0d3c Compare July 11, 2025 09:18

GomathiselviS marked this pull request as ready for review July 14, 2025 04:07

alinabuzachis changed the title ~~AAP-47753: Async create() for PatternViewSet~~ AAP-47753: Implement run_pattern_task() for PatternViewSet Jul 23, 2025

alinabuzachis force-pushed the async_create_pattern branch 3 times, most recently from 0f43195 to c8fd9b9 Compare July 24, 2025 12:27

alinabuzachis force-pushed the async_create_pattern branch 2 times, most recently from b3d8028 to bd95fbf Compare July 29, 2025 15:10

hakbailey requested changes Jul 31, 2025

View reviewed changes

alinabuzachis force-pushed the async_create_pattern branch 2 times, most recently from bdfb8dc to 4cc39a9 Compare August 4, 2025 15:36

alinabuzachis requested a review from hakbailey August 4, 2025 15:54

alinabuzachis and others added 13 commits August 5, 2025 18:53

Add custom create() method for PatternInstanceViewSet and PatternViewSet

5116c85

Signed-off-by: Alina Buzachis <[email protected]>

Update

bc08ff2

Signed-off-by: Alina Buzachis <[email protected]>

Implementation for https://issues.redhat.com/browse/AAP-47753

2af030e

Signed-off-by: Alina Buzachis <[email protected]>

Refined tasks.py to match the original

ae09b38

Rebase and some updates

00033a1

Signed-off-by: Alina Buzachis <[email protected]>

Add custom create() method for PatternInstanceViewSet and PatternViewSet

b174f53

Signed-off-by: Alina Buzachis <[email protected]>

Update

338a61f

Signed-off-by: Alina Buzachis <[email protected]>

Fix linters

b72e8e2

add aiohttp

0b35a85

Remove async

f4622a1

Signed-off-by: Alina Buzachis <[email protected]>

Update requirements

cfd0963

Signed-off-by: Alina Buzachis <[email protected]>

Fix

ca1d350

Signed-off-by: Alina Buzachis <[email protected]>

Refactored after removing async

e74afc3

alinabuzachis force-pushed the async_create_pattern branch from 3c9aa88 to 3dafb3f Compare August 6, 2025 09:35

abikouo requested changes Aug 6, 2025

View reviewed changes

Apply changes

e7986f8

Signed-off-by: Alina Buzachis <[email protected]>

alinabuzachis requested a review from abikouo August 6, 2025 12:17

abikouo reviewed Aug 6, 2025

View reviewed changes

Modify upon review

78286a9

Signed-off-by: Alina Buzachis <[email protected]>

abikouo approved these changes Aug 6, 2025

View reviewed changes

beeankha reviewed Aug 6, 2025

View reviewed changes

beeankha approved these changes Aug 6, 2025

View reviewed changes

alinabuzachis added 2 commits August 7, 2025 10:44

Fix typo

ea29bf8

Signed-off-by: Alina Buzachis <[email protected]>

Reorg

70acf24

Signed-off-by: Alina Buzachis <[email protected]>

alinabuzachis force-pushed the async_create_pattern branch from bfd75b6 to 70acf24 Compare August 7, 2025 12:11

alinabuzachis mentioned this pull request Aug 7, 2025

AAP-47731: create run_pattern_instance_task for PatternIstanceViewSet #16

Merged

GomathiselviS approved these changes Aug 7, 2025

View reviewed changes

Modify upon review

40e4434

Signed-off-by: Alina Buzachis <[email protected]>

alinabuzachis force-pushed the async_create_pattern branch from 4ed895d to 40e4434 Compare August 8, 2025 11:50

hakbailey reviewed Aug 11, 2025

View reviewed changes

core/models.py Outdated Show resolved Hide resolved

core/models.py Outdated Show resolved Hide resolved

core/tests/test_controller_client.py Outdated Show resolved Hide resolved

pyproject.toml Outdated Show resolved Hide resolved

core/utils/controller/helpers.py Show resolved Hide resolved

alinabuzachis added 2 commits August 12, 2025 13:47

Review

f21a5b0

Signed-off-by: Alina Buzachis <[email protected]>

Review

c78da48

Signed-off-by: Alina Buzachis <[email protected]>

alinabuzachis requested a review from hakbailey August 12, 2025 12:25

Undo migrations

6ade18c

Signed-off-by: Alina Buzachis <[email protected]>

hakbailey reviewed Aug 12, 2025

View reviewed changes

core/utils/controller/helpers.py Outdated Show resolved Hide resolved

core/utils/controller/helpers.py Outdated Show resolved Hide resolved

core/utils/controller/helpers.py Show resolved Hide resolved

Minor fixes

bed3404

Signed-off-by: Alina Buzachis <[email protected]>

alinabuzachis force-pushed the async_create_pattern branch from 052b727 to bed3404 Compare August 13, 2025 12:36

alinabuzachis requested a review from hakbailey August 13, 2025 12:37

hakbailey approved these changes Aug 13, 2025

View reviewed changes

alinabuzachis merged commit 3348a51 into ansible:main Aug 13, 2025
4 checks passed

	task_id (int): The ID of the task..
	task_id (int): The ID of the task.

	collection: The name of the collection (e.g., 'my_namespace.my_collection').
	collection_name: The name of the collection (e.g., 'my_namespace.my_collection').

AAP-47753: Implement run_pattern_task() for PatternViewSet #15

AAP-47753: Implement run_pattern_task() for PatternViewSet #15

Uh oh!

Conversation

alinabuzachis commented Jul 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sonarqubecloud bot commented Jul 24, 2025

Quality Gate failed

Uh oh!

hakbailey left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

abikouo Aug 6, 2025

Choose a reason for hiding this comment

Uh oh!

alinabuzachis Aug 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

abikouo Aug 6, 2025

Choose a reason for hiding this comment

Uh oh!

abikouo Aug 6, 2025

Choose a reason for hiding this comment

Uh oh!

abikouo left a comment

Choose a reason for hiding this comment

Uh oh!

alinabuzachis commented Aug 6, 2025

Uh oh!

abikouo commented Aug 6, 2025

Uh oh!

alinabuzachis commented Aug 6, 2025

Uh oh!

beeankha Aug 6, 2025

Choose a reason for hiding this comment

Uh oh!

beeankha left a comment

Choose a reason for hiding this comment

Uh oh!

GomathiselviS left a comment

Choose a reason for hiding this comment

Uh oh!

GomathiselviS Aug 7, 2025

Choose a reason for hiding this comment

Uh oh!

GomathiselviS Aug 7, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

hakbailey left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

alinabuzachis commented Jul 2, 2025 •

edited

Loading

alinabuzachis Aug 6, 2025 •

edited

Loading