Skip to content

Change the scans to be pyansys scans #375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 40 commits into from
Sep 16, 2025
Merged

Change the scans to be pyansys scans #375

merged 40 commits into from
Sep 16, 2025

Conversation

margalva
Copy link
Collaborator

@margalva margalva commented Aug 6, 2025

Change the scans to use pyansys and public actions instead of the ansys-internal scans

@margalva margalva requested a review from viseshrp as a code owner August 6, 2025 19:47
@codecov-commenter
Copy link

codecov-commenter commented Aug 6, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 45.83333% with 65 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.00%. Comparing base (6a0374a) to head (ea8f72a).

Files with missing lines Patch % Lines
...ynamicreporting/core/utils/report_remote_server.py 29.82% 37 Missing and 3 partials ⚠️
...nsys/dynamicreporting/core/utils/report_objects.py 57.14% 9 Missing ⚠️
...ynamicreporting/core/utils/report_download_html.py 33.33% 8 Missing ⚠️
src/ansys/dynamicreporting/core/utils/encoders.py 0.00% 4 Missing ⚠️
.../ansys/dynamicreporting/core/utils/report_utils.py 0.00% 2 Missing ⚠️
src/ansys/dynamicreporting/core/adr_service.py 83.33% 1 Missing ⚠️
...ynamicreporting/core/utils/extremely_ugly_hacks.py 83.33% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #375      +/-   ##
==========================================
- Coverage   81.31%   81.00%   -0.32%     
==========================================
  Files          28       28              
  Lines        7783     7824      +41     
  Branches     1440     1455      +15     
==========================================
+ Hits         6329     6338       +9     
- Misses        999     1028      +29     
- Partials      455      458       +3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

ansMHanmer
ansMHanmer reviewed Aug 7, 2025
View reviewed changes
viseshrp
viseshrp requested changes Aug 7, 2025
View reviewed changes
@margalva margalva marked this pull request as draft August 7, 2025 17:44
@margalva margalva marked this pull request as ready for review September 15, 2025 20:32
@margalva
Copy link
Collaborator Author

@viseshrp I've added the vulnerability scan to the nightly run. Let me know if there's more changes you'd like to see here.

@viseshrp
Copy link
Collaborator

@viseshrp I've added the vulnerability scan to the nightly run. Let me know if there's more changes you'd like to see here.

I ll work on some things separately. Lets get this in. Project coverage seems to have dropped 0.32%. Not sure why

@margalva margalva merged commit 393435e into main Sep 16, 2025
21 checks passed
@margalva margalva deleted the maint/scans branch September 16, 2025 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@viseshrp viseshrp viseshrp approved these changes

+1 more reviewer

@ansMHanmer ansMHanmer ansMHanmer left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@margalva @codecov-commenter @viseshrp @ansMHanmer