Skip to content

[2/3] sdks/python: enrich data with Milvus Search [Vector, Keyword, Hybrid] #35577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

mohamedawnallah
Copy link
Contributor

@mohamedawnallah mohamedawnallah commented Jul 13, 2025

Description

  • Make Milvus as extra dependency
  • Mark Milvus itests as require_docker_in_docker to run ubuntu-latest

Towards #35046.
Prev #35216.
Next #35467.

Motivation and Context

Follow-up on the discussion here #35216 (comment).


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@mohamedawnallah mohamedawnallah force-pushed the addressMilvusSearchDeps branch from 92548cd to ad0a4d4 Compare July 13, 2025 11:48
Copy link
Contributor

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

@mohamedawnallah mohamedawnallah force-pushed the addressMilvusSearchDeps branch from ad0a4d4 to e8d9659 Compare July 14, 2025 00:23
Copy link
Contributor

Assigning reviewers:

R: @claudevdm for label python.

Note: If you would like to opt out of this review, comment assign to next reviewer.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@mohamedawnallah
Copy link
Contributor Author

stop reviewer notifications

Copy link
Contributor

Stopping reviewer notifications for this pull request: requested by reviewer. If you'd like to restart, comment assign set of reviewers

@mohamedawnallah mohamedawnallah force-pushed the addressMilvusSearchDeps branch from 0af2934 to 94f8f72 Compare July 15, 2025 18:22
@mohamedawnallah mohamedawnallah marked this pull request as ready for review July 15, 2025 18:22
@mohamedawnallah
Copy link
Contributor Author

mohamedawnallah commented Jul 15, 2025

Hey @damccorm, I haven't experimented with this yet and not sure about the feasibility of this suggestion I think if we update the ubuntu version to latest for self-hosted runners it would probably solve this docker_in_docker environment issue entirely and may be future related issues

The minimum recommend ubuntu version for docker to run stably is Ubuntu Jammy 22.04 (LTS) as seen in https://docs.docker.com/engine/install/ubuntu/#os-requirements

I am still uncertain if there are beam related dependencies in the CI testing environment that depends on the existing ubuntu version 20.04

What do you think?

cc @Abacn (may help here as well – it is related to infra)

EDIT:
Just saw Danny's comment I missed those github notifications:
#35598 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant