-
Notifications
You must be signed in to change notification settings - Fork 4.4k
[2/3] sdks/python: enrich data with Milvus Search [Vector, Keyword, Hybrid] #35577
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
[2/3] sdks/python: enrich data with Milvus Search [Vector, Keyword, Hybrid] #35577
Conversation
92548cd
to
ad0a4d4
Compare
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
ad0a4d4
to
e8d9659
Compare
Assigning reviewers: R: @claudevdm for label python. Note: If you would like to opt out of this review, comment Available commands:
The PR bot will only process comments in the main thread (not review comments). |
stop reviewer notifications |
Stopping reviewer notifications for this pull request: requested by reviewer. If you'd like to restart, comment |
c7997fa
to
f4e836b
Compare
89f4319
to
c83a849
Compare
e8bba02
to
f9de00b
Compare
365f2a3
to
538adff
Compare
602a313
to
0af2934
Compare
0af2934
to
94f8f72
Compare
Hey @damccorm, I haven't experimented with this yet and not sure about the feasibility of this suggestion I think if we update the ubuntu version to latest for self-hosted runners it would probably solve this docker_in_docker environment issue entirely and may be future related issues
The minimum recommend ubuntu version for docker to run stably is I am still uncertain if there are beam related dependencies in the CI testing environment that depends on the existing ubuntu version What do you think? cc @Abacn (may help here as well – it is related to infra) EDIT: |
Description
Milvus
as extra dependencyMilvus
itests asrequire_docker_in_docker
to runubuntu-latest
Towards #35046.
Prev #35216.
Next #35467.
Motivation and Context
Follow-up on the discussion here #35216 (comment).
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123
), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>
instead.UpdateCHANGES.md
with noteworthy changes.If this contribution is large, please file an Apache Individual Contributor License Agreement.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.