Fix gprecoverseg that contains bad backport code #1259
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
my-ship-it
approved these changes
Jul 25, 2025
The option differentialResynchronization is not defined in the options,
which will cause gprecoverseg fails.
if self.__options.differentialResynchronization:
self.logger.error("gprecoverseg differential recovery failed. Please check the gpsegrecovery.py log"
" file and rsync log file for more details.")
else:
self.logger.error("gprecoverseg failed. Please check the output for more details.")
Because the code block is miss backported from GPDB upstream.
The code was added in commit 07c4d13
The upstream
greenplum-db/gpdb-archive@b84f08e2e1a299ded905921
introduced this option
gfphoenix78
force-pushed
the
fix-gprecoverseg
branch
from
270acdf to
2fe0eed
Compare
avamingli
approved these changes
Jul 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The option differentialResynchronization is not defined in the options, which will cause gprecoverseg fails.
Because the code block is miss backported from GPDB upstream. The code was added in commit 07c4d13
The upstream
greenplum-db/gpdb-archive@b84f08e2e1a299ded905921 introduced this option
Fixes #ISSUE_Number
What does this PR do?
Type of Change
Breaking Changes
Test Plan
make installcheckmake -C src/test installcheck-cbdb-parallelImpact
Performance:
User-facing changes:
Dependencies:
Checklist
Additional Context
CI Skip Instructions