feat: add support for hive 4.0.1 #2217
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinjqliu
changed the title
kevinjqliu
added a commit
that referenced
this pull request
Jul 18, 2025
<!--
Thanks for opening a pull request!
-->
<!-- In the case this PR will resolve an issue, please replace
${GITHUB_ISSUE_ID} below with the actual Github issue id. -->
<!-- Closes #${GITHUB_ISSUE_ID} -->
# Rationale for this change
Add a Makefile to `vendor/`. This helps with running commands to
regenerate `vendor/`
```
# Generate all vendor packages:
make all
# Generate individual packages:
make fb303 # FB303 Thrift client only
make hive-metastore # Hive Metastore Thrift definitions only
```
Pulled this change out of #2217
# Are these changes tested?
Yes, ran `make all` locally
# Are there any user-facing changes?
<!-- In the case of user-facing changes, please add the changelog label.
-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
This PR tries to make pyiceberg compatible with hive 4.0.1 which deprecated a few functions we're using in the hive client.
See the hive 4.0.1 changelog and [HIVE-26537] - Deprecate older APIs in the HMS. Specifically both
get_tableandget_table_objects_by_namefunctions were removedNote that we're already using hive 4.0.0, these functions were only deprecate in 4.0.1
We're replacing
get_table->get_table_reqget_table_objects_by_name->get_table_objects_by_name_reqSeveral changes to integration setup are also made to test hive 4.0.1:
vendor/to pick up latest changes to thrift client and hms clientvendor/Using hive 4.0.1 is blocked now due to apache/iceberg#12878 since spark hms connector is not yet compatible
Are these changes tested?
Are there any user-facing changes?