[SPARK-49635][SQL] Remove ANSI config suggestion in CAST error messages #53295
+40
−24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR removes the suggestion to disable ANSI mode from CAST error messages and replaces it with try_cast() function suggestions when applicable. In Spark 4.0.0, ANSI mode is enabled by default. Error messages now guide users toward ANSI-compliant alternatives like try_cast() instead of suggesting to disable ANSI mode. This implementation only suggests try_cast when the cast operation is supported, avoiding misleading suggestions. Changes: - Modified Cast.typeCheckFailureMessage to suggest try_cast when fallbackConf is None and Cast.canTryCast returns true - Changed ANSI mode error case to pass None instead of ANSI_ENABLED config - Added test case for complex type casts (Array[Int] to Array[Binary]) - Updated test expectations to reflect accurate try_cast support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR removes the suggestion to disable ANSI mode from CAST error messages and replaces it with try_cast() function suggestions when applicable.
Why are the changes needed?
In Spark 4.0.0, ANSI mode is now enabled by default. The previous error messages suggested users disable ANSI mode when encountering cast failures, which goes against the direction of the project. Instead, error messages should guide users toward ANSI-compliant alternatives like
try_cast()that handle cast failures gracefully by returning NULL.Does this PR introduce any user-facing change?
Yes. Error messages for CAST operations that fail in ANSI mode now suggest using
try_cast()instead of disabling ANSI mode, but only whentry_cast()actually supports that cast operation.Before:
After (for casts supported by try_cast):
After (for casts not supported by try_cast):
How was this patch tested?
demonstrates try_cast suggestion
behavior
Was this patch authored or co-authored using generative AI tooling?
No