Skip to content

[SPARK-49635][SQL] Remove ANSI config suggestion in CAST error messages #53295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+40 −24
Open

[SPARK-49635][SQL] Remove ANSI config suggestion in CAST error messages #53295

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -505,6 +505,10 @@ object Cast extends QueryErrorsBase {
"config" -> toSQLConf(fallbackConf.get._1),
"configVal" -> toSQLValue(fallbackConf.get._2, StringType)))

case _ if fallbackConf.isEmpty && Cast.canTryCast(from, to) =>
// Suggest try_cast for valid casts that fail in ANSI mode
withFunSuggest("try_cast")

case _ =>
DataTypeMismatch(
errorSubClass = "CAST_WITHOUT_SUGGESTION",
Expand Down Expand Up @@ -588,8 +592,8 @@ case class Cast(
Some(SQLConf.STORE_ASSIGNMENT_POLICY.key ->
SQLConf.StoreAssignmentPolicy.LEGACY.toString))
} else {
Cast.typeCheckFailureMessage(child.dataType, dataType,
Some(SQLConf.ANSI_ENABLED.key -> "false"))
// Suggest try_cast instead of disabling ANSI mode
Cast.typeCheckFailureMessage(child.dataType, dataType, None)
}
case EvalMode.TRY =>
Cast.typeCheckFailureMessage(child.dataType, dataType, None)
Expand Down
56 changes: 34 additions & 22 deletions ...talyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/CastWithAnsiOnSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@ import org.apache.spark.sql.catalyst.util.DateTimeConstants.MILLIS_PER_SECOND
import org.apache.spark.sql.catalyst.util.DateTimeTestUtils
import org.apache.spark.sql.catalyst.util.DateTimeTestUtils.{withDefaultTimeZone, UTC}
import org.apache.spark.sql.errors.QueryErrorsBase
import org.apache.spark.sql.internal.SQLConf
import org.apache.spark.sql.types._
import org.apache.spark.unsafe.types.{UTF8String, VariantVal}

Expand All @@ -51,16 +50,12 @@ class CastWithAnsiOnSuite extends CastSuiteBase with QueryErrorsBase {
assert(cast(testValue, to).checkInputDataTypes() == expectedError)
}

// Integer types: suggest config change
val configParams = Map(
"config" -> toSQLConf(SQLConf.ANSI_ENABLED.key),
"configVal" -> toSQLValue("false", StringType)
)
checkNumericTypeCast(1.toByte, ByteType, BinaryType, "CAST_WITH_CONF_SUGGESTION", configParams)
// Integer types to Binary: not supported even with try_cast, no suggestion
checkNumericTypeCast(1.toByte, ByteType, BinaryType, "CAST_WITHOUT_SUGGESTION")
checkNumericTypeCast(
1.toShort, ShortType, BinaryType, "CAST_WITH_CONF_SUGGESTION", configParams)
checkNumericTypeCast(1, IntegerType, BinaryType, "CAST_WITH_CONF_SUGGESTION", configParams)
checkNumericTypeCast(1L, LongType, BinaryType, "CAST_WITH_CONF_SUGGESTION", configParams)
1.toShort, ShortType, BinaryType, "CAST_WITHOUT_SUGGESTION")
checkNumericTypeCast(1, IntegerType, BinaryType, "CAST_WITHOUT_SUGGESTION")
checkNumericTypeCast(1L, LongType, BinaryType, "CAST_WITHOUT_SUGGESTION")

// Floating types: no suggestion
checkNumericTypeCast(1.0.toFloat, FloatType, BinaryType, "CAST_WITHOUT_SUGGESTION")
Expand Down Expand Up @@ -211,6 +206,29 @@ class CastWithAnsiOnSuite extends CastSuiteBase with QueryErrorsBase {
}
}

test("SPARK-49635: suggest try_cast for complex type casts") {
// Array[Int] to Array[Binary]: canTryCast=true (uses canCast), canAnsiCast=false
val arrayIntType = ArrayType(IntegerType, containsNull = false)
val arrayBinaryType = ArrayType(BinaryType, containsNull = false)
val arrayIntLiteral = Literal.create(Seq(1, 2, 3), arrayIntType)

val arrayResult = cast(arrayIntLiteral, arrayBinaryType).checkInputDataTypes()
evalMode match {
case EvalMode.ANSI =>
assert(arrayResult ==
DataTypeMismatch(
errorSubClass = "CAST_WITH_FUNC_SUGGESTION",
messageParameters = Map(
"srcType" -> toSQLType(arrayIntType),
"targetType" -> toSQLType(arrayBinaryType),
"functionNames" -> "`try_cast`"
)
)
)
case _ =>
}
}

test("ANSI mode: disallow variant cast to non-nullable types") {
// Array
val variantVal = new VariantVal(Array[Byte](12, 3), Array[Byte](1, 0, 0))
Expand Down Expand Up @@ -269,12 +287,10 @@ class CastWithAnsiOnSuite extends CastSuiteBase with QueryErrorsBase {
case EvalMode.ANSI =>
assert(checkResult1 ==
DataTypeMismatch(
errorSubClass = "CAST_WITH_CONF_SUGGESTION",
errorSubClass = "CAST_WITHOUT_SUGGESTION",
messageParameters = Map(
"srcType" -> "\"TIMESTAMP\"",
"targetType" -> "\"BOOLEAN\"",
"config" -> "\"spark.sql.ansi.enabled\"",
"configVal" -> "'false'"
"targetType" -> "\"BOOLEAN\""
)
)
)
Expand All @@ -297,12 +313,10 @@ class CastWithAnsiOnSuite extends CastSuiteBase with QueryErrorsBase {
case EvalMode.ANSI =>
assert(checkResult2 ==
DataTypeMismatch(
errorSubClass = "CAST_WITH_CONF_SUGGESTION",
errorSubClass = "CAST_WITHOUT_SUGGESTION",
messageParameters = Map(
"srcType" -> "\"DATE\"",
"targetType" -> "\"BOOLEAN\"",
"config" -> "\"spark.sql.ansi.enabled\"",
"configVal" -> "'false'"
"targetType" -> "\"BOOLEAN\""
)
)
)
Expand All @@ -325,12 +339,10 @@ class CastWithAnsiOnSuite extends CastSuiteBase with QueryErrorsBase {
case EvalMode.ANSI =>
assert(checkResult3 ==
DataTypeMismatch(
errorSubClass = "CAST_WITH_CONF_SUGGESTION",
errorSubClass = "CAST_WITHOUT_SUGGESTION",
messageParameters = Map(
"srcType" -> "\"BOOLEAN\"",
"targetType" -> "\"TIMESTAMP\"",
"config" -> "\"spark.sql.ansi.enabled\"",
"configVal" -> "'false'"
"targetType" -> "\"TIMESTAMP\""
)
)
)
Expand Down