fix: Console errors from various sources #34178

msyavuz · 2025-07-15T21:21:31Z

SUMMARY

After a few big migrations and theming. Dev console errors increased. I aim to fix whatever i can in this pr.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

Check browser console

ADDITIONAL INFORMATION

Has associated issue:
Required feature flags:
Changes UI
Includes DB Migration (follow approval process in SIP-59)
- Migration is atomic, supports rollback & is backwards-compatible
- Confirm DB migration upgrade and downgrade tested
- Runtime estimates and downtime expectations provided
Introduces new feature or API
Removes existing feature or API

korbit-ai · 2025-07-15T21:21:36Z

Based on your review schedule, I'll hold off on reviewing this PR until it's marked as ready for review. If you'd like me to take a look now, comment /korbit-review.

Your admin can change your review schedule in the Korbit Console

mistercrunch · 2025-07-15T21:47:02Z

Thanks for tackling this! Console has become unruly, makes it hard to use without active logging/filtering.

Copilot

Pull Request Overview

This pull request addresses console errors by migrating menu components to the newer Ant Design v5 API and refactoring shared menu logic into reusable hooks.

Converted the ShareMenuItems component into a useShareMenuItems hook that returns a MenuItem object.
Rewrote SliceHeaderControls to build its dropdown items from a MenuItem[] array and consume the new share and drill-detail hooks.
Updated table dropdowns in both TableChart and TimeComparisonVisibility to use open/onOpenChange and the menu prop instead of visible/overlay.

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
superset-frontend/src/dashboard/components/menu/ShareMenuItems/index.tsx	Refactored from a sub-component into `useShareMenuItems` hook returning a `MenuItem`.
superset-frontend/src/dashboard/components/SliceHeaderControls/index.tsx	Replaced JSX-based menu with a dynamic `newMenuItems: MenuItem[]` and integrated `useShareMenuItems`.
superset-frontend/src/components/Chart/DrillDetail/useDrillDetailMenuItems.tsx	Added `useDrillDetailMenuItems` hook for programmatic drill-detail menu generation.
superset-frontend/src/components/Chart/DrillDetail/index.ts	Exported the new `useDrillDetailMenuItems` hook.
superset-frontend/plugins/plugin-chart-table/src/TableChart.tsx	Migrated Dropdown from Antd v4 API to v5: replaced `visible`/`overlay` with `open`/`menu`.
superset-frontend/plugins/plugin-chart-ag-grid-table/src/AgGridTable/components/TimeComparisonVisibility.tsx	Updated Dropdown usage to Antd v5 `open`/`onOpenChange` and `menu` prop, removed legacy `Menu` import.

Comments suppressed due to low confidence (2)

superset-frontend/src/dashboard/components/menu/ShareMenuItems/index.tsx:45

Consider adding unit tests for the new useShareMenuItems hook to verify the generated MenuItem structure and that the click handlers are invoked correctly.

export const useShareMenuItems = (props: ShareMenuItemProps): MenuItem => {

superset-frontend/src/components/Chart/DrillDetail/useDrillDetailMenuItems.tsx:120

Add unit tests for useDrillDetailMenuItems to validate menu item generation, including disabled states and submenu offsets under different data scenarios.

export const useDrillDetailMenuItems = ({

Copilot · 2025-07-16T14:29:12Z

superset-frontend/src/dashboard/components/menu/ShareMenuItems/index.tsx

+        onClick: () => onCopyLink,
+      },
+      {
+        key: MenuKeys.ShareByEmail,
+        label: emailMenuItemTitle,
+        onClick: () => onShareByEmail,


The onClick handler returns the function reference instead of invoking it. It should be either onClick: onCopyLink or onClick: () => onCopyLink() to actually execute the copy logic.

Suggested change

onClick: () => onCopyLink,

},

{

key: MenuKeys.ShareByEmail,

label: emailMenuItemTitle,

onClick: () => onShareByEmail,

onClick: () => onCopyLink(),

},

{

key: MenuKeys.ShareByEmail,

label: emailMenuItemTitle,

onClick: () => onShareByEmail(),

Copilot · 2025-07-16T14:29:12Z

superset-frontend/src/dashboard/components/menu/ShareMenuItems/index.tsx

+        onClick: () => onCopyLink,
+      },
+      {
+        key: MenuKeys.ShareByEmail,
+        label: emailMenuItemTitle,
+        onClick: () => onShareByEmail,


The onClick handler returns the function reference instead of invoking it. It should be either onClick: onShareByEmail or onClick: () => onShareByEmail() to actually open the email share dialog.

Suggested change

onClick: () => onCopyLink,

},

{

key: MenuKeys.ShareByEmail,

label: emailMenuItemTitle,

onClick: () => onShareByEmail,

onClick: onCopyLink,

},

{

key: MenuKeys.ShareByEmail,

label: emailMenuItemTitle,

onClick: onShareByEmail,

Copilot · 2025-07-16T14:29:13Z

superset-frontend/src/dashboard/components/menu/ShareMenuItems/index.tsx

@@ -54,6 +54,7 @@ const ShareMenuItems = (props: ShareMenuItemProps) => {
    dashboardComponentId,
    title,
    disabled,
+    children,


[nitpick] The children prop is destructured but not used within this hook. Removing it will clean up the props signature.

Suggested change

children,

mistercrunch · 2025-07-28T17:19:26Z

Great to see the menu refactor happening! Gave it a shot during the theming branch effort and ended up bailing as it was pretty tangled up.

github-actions · 2025-07-30T13:09:29Z

@geido Processing your ephemeral environment request here. Action: up. More information on how to use or configure ephemeral environments

korbit-ai

Review by Korbit AI

Korbit automatically attempts to detect when you fix issues in new commits.

Category	Issue	Status
	Inconsistent HTML sanitization ▹ view	🧠 Incorrect

Files scanned

File Path	Reviewed
superset-frontend/src/components/Chart/DrillDetail/index.ts	✅
superset-frontend/src/dashboard/components/menu/ShareMenuItems/index.tsx	✅
superset-frontend/plugins/plugin-chart-ag-grid-table/src/AgGridTable/components/TimeComparisonVisibility.tsx	✅
superset-frontend/src/dashboard/components/menu/DownloadMenuItems/index.tsx	✅
superset-frontend/src/components/Chart/DrillDetail/useDrillDetailMenuItems.tsx	✅
superset-frontend/src/features/reports/ReportModal/HeaderReportDropdown/index.tsx	✅
superset-frontend/src/dashboard/components/Header/useHeaderActionsDropdownMenu.tsx	✅
superset-frontend/src/explore/components/useExploreAdditionalActionsMenu/index.jsx	✅
superset-frontend/src/dashboard/components/SliceHeaderControls/index.tsx	✅
superset-frontend/plugins/plugin-chart-table/src/TableChart.tsx	✅

Explore our documentation to understand the languages and file types we support and the files we ignore.

Check out our docs on how you can make Korbit work best for you and your team.

Loving Korbit!? Share us on LinkedIn Reddit and X

superset-frontend/src/components/Chart/DrillDetail/useDrillDetailMenuItems.tsx

+const Filter = ({
+  children,
+  stripHTML = false,
+}: {
+  children: ReactNode;
+  stripHTML: boolean;
+}) => {
+  const content =
+    stripHTML && typeof children === 'string'
+      ? removeHTMLTags(children)
+      : children;
+  return <span>{content}</span>;
+};


github-actions · 2025-07-30T13:19:15Z

@geido Ephemeral environment spinning up at http://52.33.229.141:8080. Credentials are 'admin'/'admin'. Please allow several minutes for bootstrapping and startup.

msyavuz added 3 commits July 15, 2025 23:09

fix(AgGridTable): Menu items

286c024

fix(TableChart): Menu items

49c3cbf

fix(SliceHeaderControls): Menu items

8a298b0

pull-request-size bot added the size/XL label Jul 15, 2025

github-actions bot added the plugins label Jul 15, 2025

chore: remove unused hook

88f1a46

rusackas requested a review from Copilot July 16, 2025 14:27

Copilot AI reviewed Jul 16, 2025

View reviewed changes

sadpandajoe added the review:draft label Jul 17, 2025

fix: Move menu to items prop for dashboard and explore

f8e4dd4

pull-request-size bot added size/XXL and removed size/XL labels Jul 28, 2025

geido added 2 commits July 29, 2025 16:34

merge

98203d7

fix: Align tests

14195d7

geido force-pushed the msyavuz/fix/console-errors branch from c80f57d to 14195d7 Compare July 29, 2025 15:52

geido marked this pull request as ready for review July 30, 2025 13:06

geido requested review from sadpandajoe, geido, eschutho, rusackas, betodealmeida and mistercrunch as code owners July 30, 2025 13:06

dosubot bot added change:frontend Requires changing the frontend frontend:refactor Related to refactoring the frontend labels Jul 30, 2025

geido added the testenv-up label Jul 30, 2025

korbit-ai bot reviewed Jul 30, 2025

View reviewed changes

geido approved these changes Jul 30, 2025

View reviewed changes

geido merged commit a611278 into master Jul 30, 2025
119 of 122 checks passed

geido deleted the msyavuz/fix/console-errors branch July 30, 2025 20:32

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: Console errors from various sources #34178

fix: Console errors from various sources #34178

Uh oh!

msyavuz commented Jul 15, 2025

Uh oh!

korbit-ai bot commented Jul 15, 2025

Uh oh!

mistercrunch commented Jul 15, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Jul 16, 2025

Uh oh!

Copilot AI Jul 16, 2025

Uh oh!

Copilot AI Jul 16, 2025

Uh oh!

mistercrunch commented Jul 28, 2025

Uh oh!

github-actions bot commented Jul 30, 2025

Uh oh!

korbit-ai bot left a comment •

edited

Loading

Uh oh!

This comment was marked as resolved.

Uh oh!

github-actions bot commented Jul 30, 2025

Uh oh!

Uh oh!

Uh oh!

fix: Console errors from various sources #34178

fix: Console errors from various sources #34178

Uh oh!

Conversation

msyavuz commented Jul 15, 2025

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

Uh oh!

korbit-ai bot commented Jul 15, 2025

Uh oh!

mistercrunch commented Jul 15, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Jul 16, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jul 16, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jul 16, 2025

Choose a reason for hiding this comment

Uh oh!

mistercrunch commented Jul 28, 2025

Uh oh!

github-actions bot commented Jul 30, 2025

Uh oh!

korbit-ai bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Review by Korbit AI

Korbit automatically attempts to detect when you fix issues in new commits.

Uh oh!

This comment was marked as resolved.

Uh oh!

github-actions bot commented Jul 30, 2025

Uh oh!

Uh oh!

Uh oh!

korbit-ai bot left a comment •

edited

Loading