-
Notifications
You must be signed in to change notification settings - Fork 34
Improved measurements and tables pipelines #207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Jungack
wants to merge
12
commits into
aphp:master
Choose a base branch
from
Jungack:improved-measurements
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ment pipeline bug fixes
6902b0b to
ebeb79c
Compare
4dbf961 to
b72cd44
Compare
3 tasks
ae75dc5 to
430ef22
Compare
2038fb9 to
232ca91
Compare
fe81659 to
1ffa7c6
Compare
d2e1f39 to
65669dc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Measurement pipe
pernounitin that case). This is also the case for percentages : they have a dim ofnounitand a scale of0.01ASAT ¦U/L ¦216 + ¦7-40, 7-40 is not matched)measure_before_unitvariable which lets the user indicate if the unit is generally before or after the unit. This is especially useful when considering stopwords between numerical values and units (eg in the linemg | 5 | mL | 0.3, with "|" as stopword and measure_before_unit set toFalse, the extracted ents will be5mgand0.3mL. If measure_before_unit was set toTrue, only the wrong measurement5mLwill be extracted)measurementsattribute isNoneis to match all possible measurements. In that case, all measurements are labeled "eds.measurement", even the one which were initially recognised by other defaultmeasurements(such aseds.weight)SimpleMeasurementclass to store this rangeSimpleMeasurementclass changed to addpandasdisplaying supportunit_config: degrees and dim are now stored in a subdictionnary so that the user can store a unit with multiple dimensions (useful for egmmHg)1always refers to an unit of the international system unitperassociate, even if this one was already mentionned by the userperbased on one unit not starting withper, some default terms are added based on the ones of the latter unitSimpleMeasurementobject withobject.uiSimpleMeasurementobjectsall_measurementsvariable to let the user choose whether he still wants to match all measures or only the ones he mentions. If set True, the matched measurements not requested by the user will be labelededs.measurementsand the ones requested will have the name that was defined by the user.parse_docvariable to let the user choose if he wants to parse the doc without the tables (True) or nothing (False)parse_tablesvariable to let the user choose if he wants to parse the tables (True) or not (False)measurementsvariable now acceptsvalueless_patternsin addition ofunitless patterns. This lets the user hardcode some measures which may not be detected by the measurements pipe. It is especially useful in tables when a measure is not a numerical value (eg. positive, negative)Table pipe
tableattribute which contains a dictionnary with column names, row names or column index as keycol_namesandrow_namesto let the user specify if column / row names are detected by the regex table patternto_pd_tablenow acceptsas_spanattribute. When set to True, pandas table contains spans. When set to False, the pandas table contains strings.Checklist
eds.measurementas default name instead ofeds.size)